Issue #1947: postgresql: set synchronous_commit to off #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyala
force-pushed
the
postgresql-sync-commit-off
branch
from
30cf96a to
7b4eb1f
Compare
valyala
force-pushed
the
postgresql-sync-commit-off
branch
2 times, most recently
from
944453f to
a48ab7f
Compare
|
FYI, this PR already passed travis tests. After that I updated comments in the postgresql.conf, so new test has been queued. BTW, it would be great if travis automatically cancels pending tests on PR update, so only the latest test is queued. Is it possible? |
|
@msmith-techempower , could you cancel this and this test, since they are useless now and only occupy travis resources? |
|
Ping. The PR passes tests - see https://travis-ci.org/TechEmpower/FrameworkBenchmarks/builds/116054555 . |
|
We have an agreement; LGTM! |
msmith-techempower
added a commit
that referenced
this pull request
Mar 17, 2016
Issue #1947: postgresql: set synchronous_commit to off
This was referenced Feb 17, 2022
Closed
This was referenced Aug 6, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable synchronous commits in postgresql as discussed at #1947 .