-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.3 install problem in tfb-status #4293
Comments
It looks like the location of the files in the archive changes? The ones listed in the logs are no longer at that location. Let's see what it does on the next time around. |
php7.3.0-1.... don't exist anymore, now it is php7.3.0-2..... In travis isn't failing because it recreate the first docker and later use the cache. Here create it the first time: But the tfb-status use the same cache in any new run:
CakePHP is the first framework in tfb-status that install php7.3. |
Oh, I see now. I won't be in the office for another week. We bust the cache after a few runs but if it's not busted by the time I go in, I'll do it manually. |
Solved. Looks like in one run, anybody cleaned the docker cache in the middle of the run. As only the last half of php frameworks installed correctly php. If the tfb-status don't clean the docker cache before each run, it's very important to indicate in which runs the cache was cleaned. |
Good point @joanhey - I don't think we check during the tests, and someone may have done it manually, but will verify with the team on Monday. |
@joanhey We don't bust the cache during a run, only between full runs. Not 100% sure what happened during the run that would have made the last half of php frameworks pass. Going to close this for now. |
Do you know why we always got error in some of PHP Frameworks (lumen, symfony, ...) ? Is it related to the cache? It's visible in the 3 last runs:
Errors are presents for benchmarks with database (Single Query, Multiple Queries, Fortunes, Data Updates). |
@raziel057 Check out the logs if the frameworks are affected by #4092. |
All the php frameworks that have errors with the db benchmarks, are because don't use persistent connection to the db. I tried my best to update all the frameworks to use persistent connection, but in some frameworks I can't find how to do it. #3658 And the logs don't show info about that. |
They just can not connect quickly to the bd. |
It’s strange because there were no problem in previous round. Here for example: |
In previous rounds the nginx configuration was not optimized. But the worst was that nginx was using TCP, without keep alive (persistent connection) to the php-fpm. Before simply nginx didn't send enough food (requests) to the php-fpm. Check the numbers from Round15 vs the last run. Fortunes:
Json:
Always it's recommended to use persistent connections, but a necessity if your database it's in another server. The worst thing, it is that was very difficult to find the info for use persisten connection, in most frameworks. And that Doctrine don't permit persistent connection, It's a very wrong technical decision. PD: @raziel057 the next time open a new issue, because the title of this issue is not about that. |
@joanhey Thanks you for the clarification. |
@raziel057 Check Symfony 700% faster with Workerman. |
|
In the last run all failed to install php7.3, and the actual running also have the same problem.
https://tfb-status.techempower.com/unzip/results.2018-12-23-15-04-49-016.zip/results/20181220223653/php-raw7/build/php-raw7.log
Really strange when in travis is working perfectly.
Perhaps a problem of any cache ?
The text was updated successfully, but these errors were encountered: