Skip to content

Commit 436adb6

Browse files
committed
Update Finagle to 6.36
1 parent b82f43c commit 436adb6

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

frameworks/Scala/finagle/build.sbt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ name := "finagle"
22

33
scalaVersion := "2.11.8"
44

5-
version := "1.0.1"
5+
version := "1.0.2"
6+
7+
com.github.retronym.SbtOneJar.oneJarSettings
68

79
libraryDependencies ++= Seq(
8-
"com.twitter" %% "finagle-http" % "6.34.0",
10+
"com.twitter" %% "finagle-http" % "6.36.0",
911
"com.fasterxml.jackson.module" %% "jackson-module-scala" % "2.5.3"
1012
)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
addSbtPlugin("org.scala-sbt.plugins" % "sbt-onejar" % "0.8")

frameworks/Scala/finagle/setup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
fw_depends java sbt
44

5-
sbt update compile -batch
5+
sbt 'oneJar' -batch
66

7-
sbt run &
7+
java -jar target/scala-2.11/*finagle*one-jar.jar &

frameworks/Scala/finagle/src/main/scala/Main.scala

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,17 @@ import com.twitter.io.Buf
1313
object Main extends App {
1414

1515
val mapper: ObjectMapper = new ObjectMapper().registerModule(DefaultScalaModule)
16-
val dateFormat: DateFormat = new SimpleDateFormat("E, dd MMM yyyy HH:mm:ss z")
16+
17+
val dateFormat: ThreadLocal[DateFormat] = new ThreadLocal[DateFormat] {
18+
override def initialValue: DateFormat = new SimpleDateFormat("E, dd MMM yyyy HH:mm:ss z")
19+
}
1720

1821
val helloWorld: Buf = Buf.Utf8("Hello, World!")
1922

2023
val muxer: HttpMuxer = new HttpMuxer()
2124
.withHandler("/json", Service.mk { req: Request =>
2225
val rep = Response()
23-
rep.content = Buf.Utf8(mapper.writeValueAsString(Map("message" -> "Hello, World!")))
26+
rep.content = Buf.ByteArray.Owned(mapper.writeValueAsBytes(Map("message" -> "Hello, World!")))
2427
rep.contentType = "application/json"
2528

2629
Future.value(rep)
@@ -34,13 +37,16 @@ object Main extends App {
3437
})
3538

3639
val serverAndDate: SimpleFilter[Request, Response] = new SimpleFilter[Request, Response] {
37-
def apply(req: Request, s: Service[Request, Response]): Future[Response] =
38-
s(req).map { rep =>
40+
41+
private[this] val addServerAndDate: Response => Response = { rep =>
3942
rep.headerMap.set("Server", "Finagle")
40-
rep.headerMap.set("Date", dateFormat.format(new Date()))
43+
rep.headerMap.set("Date", dateFormat.get.format(new Date()))
4144

4245
rep
43-
}
46+
}
47+
48+
def apply(req: Request, s: Service[Request, Response]): Future[Response] =
49+
s(req).map(addServerAndDate)
4450
}
4551

4652
Await.ready(Http.server

0 commit comments

Comments
 (0)