Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nitpick] Rolls Drop combo in KBX regardless of setting #477

Open
lomdr opened this issue Jan 16, 2022 · 0 comments
Open

[Nitpick] Rolls Drop combo in KBX regardless of setting #477

lomdr opened this issue Jan 16, 2022 · 0 comments
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Lua Affects Lua/Needs something fixed in Lua Status: Investigating We are looking into this one! Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Type: Upstream Bug Bug inherited from upstream

Comments

@lomdr
Copy link

lomdr commented Jan 16, 2022

Game Mode

kbx

Give an example of what is wrong

With the new tick holds in KBX it causes some interesting interactions with Dance charts that were made with "In The Groove's design philosophy" in mind. Namely, Rolls will drop your combo regardless if you have Rolls add to Combo On or Off if you happen to lift your finger in time with the tick.

Give an example of what it should look like

Rolls should keep the combo if the add to combo option is off (regardless if said roll is judged as OK or BAD) and only the OK from the Roll will add to the combo (and BAD should break it) if the Rolls add to combo option is set to on (Like in Dance?). Also, no lift caps on rolls in KBX is a good idea

@Scraticus Scraticus added Status: Investigating We are looking into this one! Engine: Lua Affects Lua/Needs something fixed in Lua Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Type: Upstream Bug Bug inherited from upstream labels Jan 17, 2022
@MrThatKid MrThatKid added the Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Lua Affects Lua/Needs something fixed in Lua Status: Investigating We are looking into this one! Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Type: Upstream Bug Bug inherited from upstream
Projects
None yet
Development

No branches or pull requests

3 participants