Fix: allow saving default player preference for downloaded files#13496
Open
fengyuqql wants to merge 1 commit into
Open
Fix: allow saving default player preference for downloaded files#13496fengyuqql wants to merge 1 commit into
fengyuqql wants to merge 1 commit into
Conversation
Collaborator
|
Please do not remove default PR template, restore it and fill it out properly and in the future use a meaningfully named separate Git branch for your pull requests, like stated in our contribution guidelines. Thank you in advance! |
Author
|
"Thank you for your guidance! I have restored the PR template and filled it out properly. I apologize for using the dev branch for this submission; as this is my first contribution, I wasn't fully aware of the branching convention. I will definitely use meaningfully named separate branches for any future contributions. Thanks again for your patience!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
devbranch.Description of the changes in the PR
This PR fixes the issue where the default media player preference for downloaded files could not be saved on modern Android versions.
Fixes the following issue(s)
Fixes #13043
Relies on the following changes
The root cause was the usage of
Intent.createChooser(), which intentionally prevents the system from showing the "Always/Just Once" options and ignores existing defaults. By passing theviewIntentdirectly toShareUtils.openIntentInApp(), the standard system resolver is restored, allowing users to set and persist their preferred media player.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence