Skip to content

Fix: allow saving default player preference for downloaded files#13496

Open
fengyuqql wants to merge 1 commit into
TeamNewPipe:devfrom
fengyuqql:dev
Open

Fix: allow saving default player preference for downloaded files#13496
fengyuqql wants to merge 1 commit into
TeamNewPipe:devfrom
fengyuqql:dev

Conversation

@fengyuqql
Copy link
Copy Markdown

@fengyuqql fengyuqql commented May 13, 2026

What is it?

  • Bugfix (user facing)
  • This PR is for the dev branch.

Description of the changes in the PR

This PR fixes the issue where the default media player preference for downloaded files could not be saved on modern Android versions.

Fixes the following issue(s)

Fixes #13043

Relies on the following changes

The root cause was the usage of Intent.createChooser(), which intentionally prevents the system from showing the "Always/Just Once" options and ignores existing defaults. By passing the viewIntent directly to ShareUtils.openIntentInApp(), the standard system resolver is restored, allowing users to set and persist their preferred media player.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Copilot AI review requested due to automatic review settings May 13, 2026 10:57
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label May 13, 2026

This comment was marked as spam.

@ShareASmile
Copy link
Copy Markdown
Collaborator

Please do not remove default PR template, restore it and fill it out properly and in the future use a meaningfully named separate Git branch for your pull requests, like stated in our contribution guidelines.

Thank you in advance!

@ShareASmile ShareASmile added bug Issue is related to a bug downloader Issue is related to the downloader template ignored The user didn't follow the template/instructions (or removed them) labels May 13, 2026
@fengyuqql
Copy link
Copy Markdown
Author

"Thank you for your guidance! I have restored the PR template and filled it out properly. I apologize for using the dev branch for this submission; as this is my first contribution, I wasn't fully aware of the branching convention. I will definitely use meaningfully named separate branches for any future contributions. Thanks again for your patience!"

@ShareASmile ShareASmile added ready for review Most of the work is done, PR is now ready for a review and removed template ignored The user didn't follow the template/instructions (or removed them) labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug downloader Issue is related to the downloader ready for review Most of the work is done, PR is now ready for a review size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Media player for downloads not selected automatically

3 participants