Filter subscriptions by channel group#13489
Open
vbrankov wants to merge 4 commits into
Open
Conversation
Tapping a channel group now selects it and filters the subscriptions grid to show only channels in that group. Tapping the already-selected group opens its recent videos feed. The selected group is highlighted with an accent-tinted card background. - Add getSubscriptionsForGroup() DAO query (INNER JOIN on group membership) - Route getSubscriptions() through the new query when a non-All group is selected - Track selected group in SubscriptionViewModel via BehaviorProcessor, making the subscriptions stream reactive to selection changes via switchMap - Add isSelected flag to FeedGroupCardItem/FeedGroupCardGridItem with visual highlight using a 15% accent colour blend on the card background - Refactor SubscriptionFragment carousel rebuild into rebuildCarousel() so it responds to both DB changes and selection changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Selecting the new "Ungrouped" group filters the subscriptions grid to show only channels that don't belong to any group, making it easy to see which channels still need to be categorised. - Add GROUP_UNGROUPED_ID = -2L constant to FeedGroupEntity - Add getSubscriptionsNotInAnyGroup() DAO query (LEFT JOIN, IS NULL) - Route getSubscriptions() to that query for GROUP_UNGROUPED_ID - Add "Ungrouped" card at the end of the groups carousel - Add feed_group_ungrouped string resource Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
getSubscriptions() is used by FeedGroupDialog to display all channels with checkmarks on those in the group. Our group-filtering logic was incorrectly intercepting that call. Extract subscriptionsFilteredByGroup() as a separate method used only by the subscriptions page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Block long-press on Ungrouped (virtual group) to prevent opening edit
dialog with invalid ID; extract groupId before the guard check
- Block feed navigation on double-tap of Ungrouped (no feed exists for
virtual groups); second tap re-selects instead of navigating
- Move selectedId read inside post{} to avoid stale capture before the
Runnable executes
- Handle GROUP_UNGROUPED_ID in getId() alongside GROUP_ALL_ID
- Replace LEFT JOIN + IS NULL with NOT EXISTS for getSubscriptionsNotInAnyGroup
(cleaner intent, avoids @RewriteQueriesToDropUnusedColumns)
- Initialise currentListViewMode from ViewModel rather than hardcoded true
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ShareASmile
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
Screen-20260509-132434.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this
wiki page.
Due diligence