Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase response time for Play/Pause button to get a more quick resume/freeze of a frame #9972

Open
6 tasks done
desmonk opened this issue Mar 26, 2023 · 1 comment
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)

Comments

@desmonk
Copy link

desmonk commented Mar 26, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

There is a significant delay when you compre the Youtube for web or the official app to NewPipe when it comes to button responsiveness of Play/Pause. This is not something that important but I would request you to check and see the delay observed as I never realized that such huge delay is present here until recently.

Why do you want this feature?

Sometimes you need to pause to a more precise frame of a video and that needs much less ltouch atency than to what we have now for Play/Pause buttons. This becomes a frustrating task to achieve when you are not able to get the exact frame of the video and than you continue to keep retrying over and over.

There are many use cases for this and will be realized once used. Randing from education to entertainment to gaming industry or sometimes just out of a curiosity, something like this can help users unknowingly!

Additional information

No response

@desmonk desmonk added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Mar 26, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) and removed needs triage Issue is not yet ready for PR authors to take up labels Mar 26, 2023
@opusforlife2 opusforlife2 added the niche Only relevant to a very small amount of people label Mar 26, 2023
@illerokcob
Copy link

illerokcob commented Apr 17, 2023

Just took a quick look into the source and it seems this line is responsible for the delay:

public static final long DEFAULT_CONTROLS_DURATION = 300; // 300 millis

Setting this to a lower value or zero would probably solve this issue, but I can be mistaken.
Edit: the delay above is for the controls to appear/disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

4 participants