Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Newpipe to Accrescent Store #9559

Open
4 tasks done
Grkrz opened this issue Dec 17, 2022 · 4 comments
Open
4 tasks done

Submit Newpipe to Accrescent Store #9559

Grkrz opened this issue Dec 17, 2022 · 4 comments
Labels
meta Related to the project but not strictly to code question Not really an issue, but more of a question about how something works

Comments

@Grkrz
Copy link

Grkrz commented Dec 17, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my question isn't listed.
  • I have taken the time to fill in all the required details. I understand that the question will be dismissed otherwise.
  • I have read and understood the contribution guidelines.

What is/are your question(s)?

Will NewPipe will be added to Accrescent _ store?

Additional information

No response

@Grkrz Grkrz added needs triage Issue is not yet ready for PR authors to take up question Not really an issue, but more of a question about how something works labels Dec 17, 2022
@opusforlife2
Copy link
Collaborator

Let's first let the store come out of alpha, at least? As far as I'm aware, they've only put test apps in it to see how everything works. Once the way is open for the general dev community to submit apps, I don't see why Newpipe can't be added.

@opusforlife2 opusforlife2 added meta Related to the project but not strictly to code and removed needs triage Issue is not yet ready for PR authors to take up labels Dec 18, 2022
@opusforlife2 opusforlife2 changed the title Accrescent _ store Submit Newpipe to Accrescent Store Dec 18, 2022
@matchboxbananasynergy
Copy link

matchboxbananasynergy commented Dec 21, 2022

Accrescent is currently in Alpha, as @opusforlife2 mentioned above. Developers can submit their apps (the apps currently on the store are not test apps - they're production ready), but they have to be whitelisted to be able to submit their app.

As with all alpha software, developers who adopt Accrescent at this time should expect hiccups which NewPipe may not be open to at this time.

Also, there are the requirements of the store to take into account as defined by Accrescent's documentation:

https://accrescent.app/docs/index.html

As far as I can tell, NewPipe is currently on targetSDK 29, for example, which doesn't currently meet Accrescent's criteria (I believe the current minimum is targetSDK 31). That said, I do remember seeing an issue on the repo to raise the targetSDK, so when that happens, it should be good to go when the developers of NewPipe want to submit it (and assuming they're whitelisted - although I don't see an obvious reason why not).

EDIT: It seems that targetSdk 33 is in NewPipe's future, so the targetSdk requirements of Accrescent should be met at that point. If NewPipe continues to keep that up to date, it shouldn't be an issue going forward.

NewPipe's targetSdk is now 33. Assuming that it doesn't lag behind again, this is no longer an issue.

That said, it seems that currently NewPipe uses SYSTEM_ALERT_WINDOW which I understand is being used for PiP. There seems to be an issue about this and it seems like it's planned for this to eventually be changed, at which point this permission will probably be gone. I bring it up because it would likely be a blocker for Accrescent inclusion as things stand.

Another thing that comes to mind is NewPipe's "updater" which notifies people about a new version and takes them to GitHub to download it. I believe that the version in the main F-Droid repo doesn't have that, or I couldn't find it, at the very least, so there must be a flavor that removes that. That flavor would probably be the one that needs to be used for Accrescent, as having a feature that pushes people to update from another source would change the installer of record for NewPipe (or any other app) and break unattended updates until you updated the app through Accrescent manually once more to make Accrescent the installer of record again.

I will continue to look into things and update this post should I find anything else. It seems that while NewPipe may not fully meet the store's requirements just yet, most (if not all) of what it needs to change are planned already, so I'm hopeful that a day will come when it will be eligible without something that wouldn't be done anyway needing to be done.

@RokeJulianLockhart

This comment was marked as outdated.

@Krvopije

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code question Not really an issue, but more of a question about how something works
Projects
None yet
Development

No branches or pull requests

5 participants