Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed refresh operation should query network state before starting #8869

Open
6 tasks done
opusforlife2 opened this issue Aug 23, 2022 · 1 comment
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed GUI Issue is related to the graphical user interface

Comments

@opusforlife2
Copy link
Collaborator

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

It's a small optimisation, but the app should check for an active internet connection before attempting to refresh the feed. It should show a toast saying Internet isn't available if that is the case.

Why do you want this feature?

When you have Internet turned off on your device, and try to refresh the feed, the app actually goes through the entire list of subscriptions and fails to load new videos from each one.

It's not an error from the app's side, so the UI shouldn't behave as if something went wrong. A toast punting the blame towards the lack of internet connection would make things clearer.

Additional information

No response

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up GUI Issue is related to the graphical user interface feed Issue is related to the feed and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 23, 2022
@opusforlife2
Copy link
Collaborator Author

Related: #7651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant