Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'Open in Browser' button to the broken video page #8800

Closed
5 tasks done
astatine opened this issue Aug 15, 2022 · 9 comments · Fixed by #9180
Closed
5 tasks done

Add a 'Open in Browser' button to the broken video page #8800

astatine opened this issue Aug 15, 2022 · 9 comments · Fixed by #9180
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@astatine
Copy link

astatine commented Aug 15, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Currently, NewPipe shows the 'Sorry, something went wrong' page with the big frowny face when the video hasn't premiered yet, and when NewPipe itself is broken. That page has Report and Retry buttons with expected functionality.

For both these cases, it would be great if a Open in Browser button is added to the page.

Sorry, something went wrong.

Why do you want this feature?

This would enable the user to know when the video will premiere, and in the second case would enable the user to watch the video.

Additional information

No response

@astatine astatine added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Aug 15, 2022
@SameenAhnaf
Copy link
Collaborator

@mhmdanas Duplicate of #6624

@triallax
Copy link
Contributor

@SameenAhnaf no, this isn't a duplicate of #6624. This issue requests an "Open in browser" button when errors occur, while that issue asks for showing more information in case of errors.

@opusforlife2 opusforlife2 added GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 16, 2022
@opusforlife2
Copy link
Collaborator

Would really prefer it if the browser is sent a Piped/Invidious link instead of a YT one.

@triallax
Copy link
Contributor

I suppose that could be added as a setting.

@opusforlife2
Copy link
Collaborator

#2351 would be a prerequisite then.

@YonghaoDeng
Copy link
Contributor

Hey, could I work on this issue? :))

@opusforlife2
Copy link
Collaborator

@YonghaoDeng Please give some idea of how you will implement this? A button under Report and Retry saying "Open in Browser"? Or something else?

@YonghaoDeng
Copy link
Contributor

s

I will firstly add a button called "Open in Browser" in the error_panel.xml, then write code like adding onclicklistener in the ErrorPanelHelper.kt file to enable clicking this button to open the browser.
I also found a broken video page example in the NewPipe app, and I add the button like this:
屏幕截图 2022-10-22 105608

@YonghaoDeng
Copy link
Contributor

I have submitted the PR, can you review it? if it has some questions, you can talk to me. @opusforlife2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants