Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While in full-screen, pressing the back button sometimes goes to the previous video, in addition to leaving the full screen #8659

Open
5 tasks done
stdedos opened this issue Jul 19, 2022 · 3 comments
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@stdedos
Copy link

stdedos commented Jul 19, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.23.1

Steps to reproduce the bug

  1. Open a video in full screen
  2. Move to the next video
  3. maybe: don't wait for the video to start playing
  4. Press the back button to leave full screen

Expected behavior

Full screen is dismissed

Actual behavior

Previous video starts playing

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

S8

Additional information

On top of #8658

@stdedos stdedos added the bug Issue is related to a bug label Jul 19, 2022
@opusforlife2
Copy link
Collaborator

maybe: don't wait for the video to start playing

Try this a bunch of times and see if that "maybe" turns into a "definitely".

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jul 25, 2022
@stdedos
Copy link
Author

stdedos commented Jul 25, 2022

Steps to reproduce the bug

  1. Open a video in full screen
  2. Move to the end screens
    2.5. Notice that the fullscreen was stopped, and you have "NP portrait" in landscape mode
  3. Press the next video to play
  4. Before the video loads, press the back button "to leave full screen" (i.e. switch to landscape)

Consistent repro

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jul 25, 2022
@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Jul 26, 2022
@Monirzadeh
Copy link

it happen when you play a new video without closing or finish previous video.
if first video close than back functionality work correctly.
is it possible to fix that? relay annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants