Rotating phone while video loading stops loading video

[emjas92]

Checklist

• I am able to reproduce the bug with the latest version.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.22.1

Steps to reproduce the bug

1. Ensure auto-rotate is enabled
2. Start playing a video in portrait mode
3. Minimise video by swiping down
4. Select another video
5. While the video is loading, rotate the phone to landscape

Expected behavior

Newly selected video loads and plays.

Actual behavior

The previous video remains shown and the selected video is forgotten.

It seems like the new video is not 'saved' to the view before the view gets reloaded in landscape mode.

Screenshots/Screen recordings

MP4_20220405_231752.mp4

MP4_20220405_232241.mp4

Logs

No response

Affected Android/Custom ROM version

LineageOS 17.1

Affected device model

Nokia 6.1

Additional information

Sometimes the new video is loaded in landscape mode if the current one was paused

[GGAutomaton]

I would like to work on this issue.

[GGAutomaton]

It seems that somebody considered this before.

NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

Lines 1865 to 1870 in 860d28e

	// They are not equal when user watches something in popup while browsing in fragment and
	// then changes screen orientation. In that case the fragment will set itself as
	// a service listener and will receive initial call to onMetadataUpdate()
	if (!queue.equals(playQueue)) {
	return;
	}

But this does not work since queue is always equal to playQueue after being updated by onQueueUpdate().

NewPipe/app/src/main/java/org/schabi/newpipe/player/Player.java

Lines 4094 to 4095 in 8441aff

	notifyQueueUpdateToListeners();
	notifyMetadataUpdateToListeners();

Simply swapping them does not take effect.

I'm afraid that I could not fix it. The update logic is quite complex and I don't know if there is a good way to fix it.
Sorry for that.

[opusforlife2]

No worries. 👍

[wildwestrom]

Glad there's already an issue.

"The update logic is quite complex..."

That's a problem. I've never done android apps before so it would take me a long time to figure out how everything works.

[seniorm0ment]

Made a note here about a similar issue. Hope it gets fixed soon, it is a very frustrating bug that makes it difficult to just use the app and has been around for months.
#9643 (comment)