Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to Play Queue screen from video details #7208

Open
4 tasks done
TippyLion28 opened this issue Oct 7, 2021 · 6 comments
Open
4 tasks done

Return to Play Queue screen from video details #7208

TippyLion28 opened this issue Oct 7, 2021 · 6 comments
Labels
bug Issue is related to a bug

Comments

@TippyLion28
Copy link

TippyLion28 commented Oct 7, 2021

Checklist

Steps to reproduce the bug

Fire up the background audio player and open the Play Queue screen from the notification. Long-press a video and tap "details". Now swipe down the video screen as to minimise the video details.

Actual behavior

App returns to the main NewPipe window.

Expected behavior

App should return back to the Play Queue.

Screenshots/Screen recordings

Can provide a screen recording if necessary.

Logs

Device info

  • Android version/Custom ROM version: 11, LineageOS 18.1
  • Device model: Poco F1
@TippyLion28 TippyLion28 added the bug Issue is related to a bug label Oct 7, 2021
@SameenAhnaf
Copy link
Collaborator

Wouldn't #5235 solve the bug for you?

@TippyLion28
Copy link
Author

Yes, it would.

However, that is a feature request for something that does not yet exist in NewPipe, and to be honest I think the current implementation is fine.

What I'm asking for is a bugfix for a feature that exists today. If #5235 gets implemented, this issue is redundant. However it has not been implemented, so this issue stands.

@goyalyashpal

This comment was marked as resolved.

@opusforlife2
Copy link
Collaborator

@yashpalgoyal1304 It works fine for me. Please check again.

@TippyLion28 It could lead to complications, as currently the main player shows the play queue already. So you would have access to the same play queue using 2 different actions.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 12, 2022
@TippyLion28
Copy link
Author

The video info screen does not show the play queue when the background player is being used.

If I do Background Queue > Long press a video and select "Details" > then press the hardware back button on my device nothing happens. If I press it again it just minimises the video info screen.

What I am proposing is that pressing the hardware back button should send you back to the background play queue

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 12, 2022
@opusforlife2
Copy link
Collaborator

Ah. That makes sense. Please update your description to say that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

4 participants