Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play button on a connected device doesn't resume playback after exiting NewPipe. #7086

Open
4 tasks done
Rikests opened this issue Sep 10, 2021 · 8 comments
Open
4 tasks done
Labels
bug Issue is related to a bug

Comments

@Rikests
Copy link

Rikests commented Sep 10, 2021

Checklist

Steps to reproduce the bug

  1. Connect an external device with play/pause button, like Bluetooth speaker/headset.
  2. Open NewPipe.
  3. Start playback of media in background or other mode.
  4. Open the Android notification drawer.
  5. Press "X" on the NewPipe playback notification in the notification drawer.
  6. Press Play/Pause button on the connected external device.
  7. NewPipe notification appears with a hourglass icon instead of play button.
  8. Sit in silence.

Actual behavior

This happens when NewPipe is closed and has been the last app playing media. Newpipe does not resume playback when play/pause button is pressed on a connected external device. Instead It just opens a Notification with a hourglass icon.
This is annoying when trying to resume playback without interacting with the phone directly. Like when I am driving a car with a bluetooth audio system or using a headset. I have to take the phone out of the pocket, navigate to the media, and press play. This is tedious and can be a bit dangerous when driving a car or a bike.

Expected behavior

I expect NewPipe to resume playing the last playlist, in background mode, or maybe in the mode that was last active.

OR pass the playback command to the next media app that has been open before NewPipe, like VLC, RadioDroid, etc...

Screenshots/Screen recordings

Here is a screen recording of the issue, note that I am pressing the play button on an external bluetooth speaker, just watch the newpipe notification icon appear to know when I am pressing it.
Video will be deleted on Nov 09, 2021
https://files.fm/f/kupzscvun

Here is a screenshot of the notification.
image

Logs

Device info

  • Android version/Custom ROM version: Android 10 / LineageOS 17.1
  • Device model: SM-G950F (Samsung galaxy s8)

This was also happening on my OnePlus X

Thank you for developing and maintaining this wonderful app!
-Rikests

@Rikests Rikests added the bug Issue is related to a bug label Sep 10, 2021
@ghost
Copy link

ghost commented Sep 11, 2021

#5122

@ackzsel
Copy link

ackzsel commented Sep 13, 2021

Could this be related to #2373 which should get fixed in 0.21.10?

@Rikests
Copy link
Author

Rikests commented Sep 21, 2021

Could this be related to #2373 which should get fixed in 0.21.10?

Now, after the 0.21.10 release, we can see that It was not related. I upgraded to version 0.21.10 and this issue is still happening.

Screenshot_20210921-215457_Trebuchet

@TacoTheDank
Copy link
Member

Hello, does this issue still occur on version 0.22.1?

@ackzsel
Copy link

ackzsel commented Mar 29, 2022

Just checked. For me it still does on 0.22.1. What I did:

  • listen to music (using vanilla) over bluetooth headphones
  • open newpipe
  • start any yt video
  • press X to close video
  • press play button on bt headphones

Now the [Unknown] track starts
If I close newpipe and/or lock my phone before pressing play the same thing happens. After I manually restart the music the play button is assigned to vanilla again.

@opusforlife2
Copy link
Collaborator

This happens because the OS registers Newpipe as a media app once you play a video in it. Any OS only remembers the last media app that was used. Another place where this shows up is #3903 (comment).

I don't think anything can be done about this, but I'm not a dev.

@Rikests
Copy link
Author

Rikests commented Apr 18, 2022

I don't think anything can be done about this, but I'm not a dev.

It could load up the last video/playlist that was played from history in the background player, so that it doesn't just stand there with empty notification, like the one in pic below. When I press play in the car, I often don't care what starts playing as long as something plays.

image

@flt4ever
Copy link

flt4ever commented Jan 6, 2023

1st, great app much appreciate its development! Now, regarding this resume bug, I can confirm it's still happening with version 0.24.1. For me, the test is by getting back in my car after a stop anywhere. I can also say that resuming is no problem when using DI.fm app...not sure about others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

5 participants