Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button for the loop #6914

Closed
3 tasks done
Angelk90 opened this issue Aug 12, 2021 · 18 comments · Fixed by #10396
Closed
3 tasks done

Button for the loop #6914

Angelk90 opened this issue Aug 12, 2021 · 18 comments · Fixed by #10396
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@Angelk90
Copy link
Contributor

Checklist

Describe the feature you want

image

Button for the loop

As you can see from the image, a button is missing for loop playback of the video.

Is your feature request related to a problem? Please describe it

To be able to play a video in loop.

@Angelk90 Angelk90 added the feature request Issue is related to a feature in the app label Aug 12, 2021
@triallax
Copy link
Contributor

I think such a button would not fit well in there, but somewhere in the player itself instead would be better.

@triallax triallax added the player Issues related to any player (main, popup and background) label Aug 15, 2021
@Angelk90
Copy link
Contributor Author

@mhmdanas :
If you take a look at this comment: #1317 (comment), if you see in the second image, there is a bottomsheet menu I would recommend putting it there.

@CodeCubeNeo
Copy link

Any progress on this? It is a really basic feature, so I think it should be implemented.

@SameenAhnaf SameenAhnaf mentioned this issue May 25, 2022
5 tasks
@Stypox
Copy link
Member

Stypox commented May 26, 2022

There is a button both in the notification (can be enabled in settings), in queue menu of the main player, and in the background/popup play queue activity. The only time when this button can't be accessed easily is when the player is in fullscreen and there is only one item in the queue, which causes the queue menu button to be hidden. But if you are watching fullscreen only one video, then there is a replay button in front of you if you want to replay the video, so there is no need for another button.

@Stypox Stypox closed this as completed May 26, 2022
@AudricV
Copy link
Member

AudricV commented May 26, 2022

But if you are watching fullscreen only one video, then there is a replay button in front of you if you want to replay the video, so there is no need for another button.

Indeed, but let's say you want to repeat automatically the content. Without using the player notification, you can't, you need to do this automatically. Maybe we should implement a menu like on the YouTube app to put such options.

@Stypox
Copy link
Member

Stypox commented May 27, 2022

I get it, but I think it would just add one button that in most cases is redundant and for which there are alternatives. So I'd prefer not to add it.

@theridon
Copy link

It's not redundant because there isn't an alternative button when you're actually in the app. You have to drag down the notification bar to get this button which is inconvenient, unintuitive, and if you've disabled notifications, impossible. I think it would greatly benefit the userbase and app functionality to have a regular loop button in the app, say on the screen or below it.

@triallax
Copy link
Contributor

I get it, but I think it would just add one button that in most cases is redundant and for which there are alternatives. So I'd prefer not to add it.

I agree with @theridon, and I am not convinced by your argument. By your logic, we could say that the pause/start button of the player is redundant, since the notification player has the exact same button, but we know that makes no sense.

@Stypox
Copy link
Member

Stypox commented Jul 20, 2022

Maybe we could just make the queue button available even when there is only one item in the queue? From there a user could access the repeat button.

@Chipioki
Copy link

From UX perspective: I've been using newpipe for over a year now and I have always wondered why there's no loop function. I simply couldn't find it. Even after I had the idea to create a playlist, the repeat option was everything but intuitive.

Just do everyone a favor and add that button to the player, please. No one gets hurt, but many will be happy. Thank you!

@ttodua
Copy link

ttodua commented Aug 27, 2023

It's quite surprising this feature is not here.
I, my friends, family members, everyone had been asking, "show me how do I loop the video"? even I, had to google for the answer initially.
this is so basic feature, that shouldnt need to read docs and faqs to find out it, or ask other uaers "how to repeat the video".
search on reddit, how many this exact questions had been open under "NewPipe" subreddit.
I think that just Author's personal subjective preference is that button was not there, otherwise all arguments and facts tell opposite. every existing player has that option in place for easy access, and i dont know how NewPipe redefined "what is better for users" , while users are actually asking in contrary, because current approach is outright unintuitive and illogical. we just search video on YT, play it and want to loop it. no one among us "adds it to playlists and then goes to playlist, and chooses to loop the playlist". this is ridicilous.
so, i think it's just developer of NewPipe who does not like that button.

@amark
Copy link

amark commented Jan 10, 2024

I still don't know how to loop, I am a developer, have read this thread.

Android notification pull down does not give me a loop option, only play and left/right.

Playlist shows I can loop(?) 1 time which isn't looping.

How do I loop? Can we please add?

@ttodua

This comment was marked as outdated.

@opusforlife2
Copy link
Collaborator

Open the queue using the queue button in the player controls. The loop button is there, along with the shuffle button.

@ttodua
Copy link

ttodua commented Jan 12, 2024

Open the queue using the queue button in the player controls. The loop button is there, along with the shuffle button.

i don't think anyone needs queue shuffling...
the loop button should be directly in video controls, there should not be the need to enter queue and so on, in my opinion.

@opusforlife2
Copy link
Collaborator

@ttodua Did you try the method I gave you?

@ttodua
Copy link

ttodua commented Jan 12, 2024

@ttodua Did you try the method I gave you?

thanks for suggestion, i see it do work, but entering queue and setting the loop there is not a straightforward way in my opinion. it would have been a reasonable to allow users to customize themselves, if they want repeat button directly in video controls, so if there was optionality, it might have solved the problem.
i think for users it's not straightfowrad to guess where the loop could be (unless they ask one by one and read your comment)

@opusforlife2
Copy link
Collaborator

You can open a new issue for it. The player UI will undergo a redesign in the rewrite, so things like this need to be thought about from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants