Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show info" and "Video player" work the same for shared videos #6500

Open
4 tasks done
SameenAhnaf opened this issue Jun 16, 2021 · 5 comments
Open
4 tasks done

"Show info" and "Video player" work the same for shared videos #6500

SameenAhnaf opened this issue Jun 16, 2021 · 5 comments
Labels
bug Issue is related to a bug

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jun 16, 2021

Checklist

Steps to reproduce the bug

Actual behaviour

Unfortunately, 'Show info' option in "Preferred 'Open' Action" is useless for videos. Videos tend to start according to 'Auto-play' setting. However, 'Video player' option works the same. According to me, 'Show Info' option should not start playback automatically.

Expected behavior

This is how "Preferred 'Open' Action" should work for shared videos.
Show info: Don't auto-play videos
Video player: Auto-play videos on main player

Screenshots/Screen recordings

https://drive.google.com/file/d/12ZM8DqezvykcGHXttvka3dvoBxyoc9nC/view?usp=drivesdk

Logs

Device info

  • Android version/Custom ROM version:
  • Device model:
@SameenAhnaf SameenAhnaf added the bug Issue is related to a bug label Jun 16, 2021
@SameenAhnaf
Copy link
Collaborator Author

SameenAhnaf commented Jun 16, 2021

@sauravrao637 Thanks for your amazing contribution 😃.

As you may remember, #6371 is not fully resolved as stated in #6385 (comment). If you are free, please have a look at this issue.

Have a great day. Sorry for the pinge.

@rancidfrog
Copy link

rancidfrog commented Jun 17, 2021

It is not useless.
Since at the moment it is the only way to share new videos to queue.
Steps:

  • Play video in background
  • Share to newpipe
  • select show info
  • long press background to enqueue

Without this there is no way to share to enqueue
So it is not useless at all, because show info does not play video so it does not affect current queue

Until queue is handled via #5850
Show info can be used as a workaround for queuing videos

@sauravrao637
Copy link
Contributor

sauravrao637 commented Jun 17, 2021

This is how "Preferred 'Open' Action" should work for shared videos.
Show info: Don't auto-play videos
Video player: Auto-play videos on main player

Did you guys read the "Expected behaviour"? The reason why I am saying it useless is the fact that I knocked a couple of devs. Yet, the issue isn't still fixed now.

Videos tend to start according to 'Auto-play' setting.

This is what happens unexpectedly. Watch the video for full explanation.

For first and second case, I enabled "Auto-play" but chose "Show info" and "Video info" . Video tends to auto-play in both cases.

The same goes for third and fourth cases. Video doesn't tend to play as "Auto-play" setting is "Never".

https://drive.google.com/file/d/12ZM8DqezvykcGHXttvka3dvoBxyoc9nC/view?usp=drivesdk

I get the real issue now, the video was real helpful, you may add this in the issue itself.
By the way it might be the case settings are applied after the app restart, did u try that?

@SameenAhnaf

This comment has been minimized.

@sauravrao637
Copy link
Contributor

@SameenAhnaf To be honest to fix this issue one should me more than familiar with the NewPipe codebase, which (sadly) I'm still not, so will have to wait for some core member to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants