Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stabilise the caption text #6172

Open
4 tasks done
XilinJia opened this issue Apr 25, 2021 · 8 comments
Open
4 tasks done

Please stabilise the caption text #6172

XilinJia opened this issue Apr 25, 2021 · 8 comments
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@XilinJia
Copy link

XilinJia commented Apr 25, 2021

Checklist

Steps to reproduce the bug

  1. Go to 'https://www.youtube.com/watch?v=Y_ejCmX008s', or basically any video
  2. turn on captions
  3. choose "auto-generated"

Actual behaviour

With the auto-generated caption, the text are centrally justified. This causes the text to shift back and forth when changing lines, making them hard to track by the eye.

Expected behavior

The start position of each line of text should stay the same, so perhaps left-justification is ideal, as YouTube does.

Screenshots/Screen recordings

Logs

Device info

The behavior appears on various devices, all with Android 9 as I tried.

@XilinJia XilinJia added the bug Issue is related to a bug label Apr 25, 2021
@triallax triallax added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Apr 25, 2021
@hafizmuhmmadismail
Copy link

Same problem here

@litetex
Copy link
Member

litetex commented May 2, 2021

Hmm this is interesting:
It seems like the subtitles itself determine where they are (→ ExoPlayer doc):
e.g. https://www.youtube.com/watch?v=BiDvLshi9CY

  • English -> Text is centered (and jumps)
    grafik
  • English/auto-generated -> Text is aligned left
    grafik

The above works for YT and the YT app, however the auto-generated text is also centered in the NewPipe app.

Maybe something is lost while parsing the data from YT?

@snouup
Copy link

snouup commented Aug 7, 2021

Another problem related to subtitle placement when viewing video in landscape mode - on some phones like google pixels, long subtitles can overlap with the front camera, thus a part of the subtitle becomes unreadable.
I advise newpipe to pad the subtitle region by the size of the notification bar to avoid this problem.

@Angelk90
Copy link
Contributor

Angelk90 commented Aug 13, 2021

@LeoK987, @hafizmuhmmadismail, @litetex, @snouup:

There is also a font size problem.

Youtube:
image

NewPipe:
image

@SameenAhnaf : Isn't there a way inside the app that allows you to customize the font size?

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Aug 13, 2021

@Angelk90 Yes, Go to Settings>Appearance>Captions>Caption size and style.

Also, please avoid pinging so many people from next time.

@Angelk90
Copy link
Contributor

Angelk90 commented Aug 13, 2021

@SameenAhnaf : I think there is a problem with the videoplayer subtitles, I put as "very small" font size nothing changed, I closed and reopened the app.

Furthermore there is also the following problem popup:

image

@Angelk90
Copy link
Contributor

Angelk90 commented Oct 3, 2021

@TobiGr : There is also a font size problem.

Youtube:
image

NewPipe:
image

I also did this: 'Settings'> 'Appearance'> 'Captions'> 'Caption size and style'.

But the font does not change, it is very small.
Tested on Tablet.

@MilaMurry
Copy link

Yeah when is this going to be fixed? It's already 2024 and the issue still persists. Changing the settings in Settings > Appearance > Captions > Caption size and style has no effects and it is not a solution because it will affect other apps. Just adding a slider for the font should have solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

8 participants