Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Split Screen maximize video #6044

Closed
3 tasks done
Dakkaron opened this issue Apr 10, 2021 · 1 comment · Fixed by #6059
Closed
3 tasks done

In Split Screen maximize video #6044

Dakkaron opened this issue Apr 10, 2021 · 1 comment · Fixed by #6059
Labels
feature request Issue is related to a feature in the app

Comments

@Dakkaron
Copy link
Contributor

Dakkaron commented Apr 10, 2021

Checklist

Describe the feature you want

When in split screen mode, the video should be maximized to fill the area, the way the official Youtube app does it.
Screenshot_20210410-231531

At least, when the full screen button is pressed, this should be the result. Currently, the full screen button does nothing in split screen mode.

Is your feature request related to a problem? Please describe it

When I use NewPipe in split screen mode, the app tries to squeeze the full view into the tiny split screen view, instead of displaying only the video. This makes it very tiny.
Screenshot_20210410-231448

Additional context

How will you/everyone benefit from this feature?

This feature would allow multitasking while watching videos. Currently, I am stuck with a tiny video and half the screen wasted.

@Dakkaron Dakkaron added the feature request Issue is related to a feature in the app label Apr 10, 2021
@Dakkaron
Copy link
Contributor Author

I made a build where DeviceUtils.isTablet() always returns false and there the problem does not occur. So it appears to only be a problem when in tablet mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant