Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ripple animation finish when tapping on video thumbnail #5919

Closed
3 tasks done
opusforlife2 opened this issue Mar 27, 2021 · 5 comments
Closed
3 tasks done

Let ripple animation finish when tapping on video thumbnail #5919

opusforlife2 opened this issue Mar 27, 2021 · 5 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@opusforlife2
Copy link
Collaborator

Checklist

Describe the feature you want

I think it would be better if the ripple animation is allowed to finish before opening the player. This would bring some uniformity to the UX and also hide poor loading times from the user, giving the impression of a smoother experience.

Is your feature request related to a problem? Please describe it

The ripple animation last for however long it takes the video stream to load. Sometimes it is allowed to finish animating, and sometimes it is cut off when the player opens, making it seem a bit janky.

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Mar 27, 2021
@avently
Copy link
Contributor

avently commented Mar 27, 2021

Please, show a video of what you mean

@opusforlife2
Copy link
Collaborator Author

Screen recording frame rate is too low to be able to capture it. But if you try to reopen cached videos, you'll definitely encounter it on your first or second try. It is pretty noticeable.

@avently
Copy link
Contributor

avently commented Mar 27, 2021

I bought another phone and I see a ripple effect everywhere.
So you propose to wait before animation ends and only then to open a video screen? Isn't it a atrange that you want to look at animation more than on a video itself?

@opusforlife2
Copy link
Collaborator Author

It's not like the animation takes ages. It's just fractions of a second. :P

Another place where this is very noticeable is when you tap on the logo to get the menu to switch between services. The animation never gets completed.

Alternate solution: Is it possible to replace the circle rippling outwards animation by a general 'highlighting' of the UI element? So instead of a circle spreading outwards, which can get stopped in the middle, it would just be a general fade in of a translucent white layer over the whole thumbnail, or something.

@opusforlife2
Copy link
Collaborator Author

There's no ripple at all on newer Android versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

2 participants