Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the popup player #5478

Closed
3 tasks done
alienthief opened this issue Jan 22, 2021 · 10 comments
Closed
3 tasks done

Revamp the popup player #5478

alienthief opened this issue Jan 22, 2021 · 10 comments
Labels
feature request Issue is related to a feature in the app

Comments

@alienthief
Copy link

Checklist

Describe the feature you want

The current popup player needs some revamp like:

  1. Changing the bottom X button that closes the player by dragging towards it to an X inside the mini player (see screenshot for context). This one is a hustle sometimes you should try multiple times to get that spot that highlights the player in red and closes
  2. Smooth switching between popup and regular player. Currently when you swith between the two players it stops for a second
  3. The resizing text when adjusting the popup size needs to go, everybody knows they are resizing!

Is your feature request related to a problem? Please describe it

Yes because sometimes inconvenience is a problem.

Additional context

A popup player from another video player (MX):

Screenshot_20210122-193051

How will you/everyone benefit from this feature?

People will benefit from this because they will no longer be hustling to close the mini player they will just click the x button in the player to close, they won't experience that delay at the player switch and finaly they won't see that big ugly resizing text when adjusting the player size.

@alienthief alienthief added the feature request Issue is related to a feature in the app label Jan 22, 2021
@Orion983
Copy link

Great idea! This would be a welcome addition for me

@alienthief
Copy link
Author

alienthief commented Jan 22, 2021

@skyGtm

Similar issue corresponding to point 1 is #5455 (comment)
This has been fixed #5458
Wait until release version of the app

The issue/comment you referenced which is yours btw is no way close to this and also that PR you referenced is about "fixing x close button animation". I don't know if you understood what I'm talking about but you were supposed to read before commenting

@vkay94
Copy link
Contributor

vkay94 commented Jan 22, 2021

Your second point (smooth switching) is not limited to the popup, it happens for all kinds of types. There is also a duplicate: #5016

@opusforlife2
Copy link
Collaborator

It's actually older than that: #2863.

@triallax
Copy link
Contributor

@alienthief this issue requests multiple features. Could you please open separate issues for each of those (except 2, since there's #5016 for that)?

@alienthief
Copy link
Author

@mhmdanas 🤦‍♂️ it's a revamp about one specific feature. popup player. it was supposed to have multiple points that's why i wrote "revamp" on the title please reopen the issue

@triallax
Copy link
Contributor

It doesn't matter that we're talking about one existing feature. The issue is precisely with the multiple points.

@alienthief
Copy link
Author

@opusforlife2 what do you think about @mhmdanas point of closing this issue?

@opusforlife2
Copy link
Collaborator

@alienthief Of your 3 points, point 2 is a duplicate as vkay and I linked already.

Anyway, this is not a revamp. It's two separate feature requests/bugs. Why? Because the code/UI changes aren't related at all. A dev could browse through issues, stumble on one of those, and choose to implement the removing "resizing" one, for example, and it would have no effect on the other.

So it is better that there are two different issues for it.

@B0pol
Copy link
Member

B0pol commented Feb 5, 2021

I don't think we should change the popup player UI. It's a legacy piece of code IMO.

We should use Android's Picture in Picture API instead (Android 7/8+). There is an issue for that: #2223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

6 participants