-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp the popup player #5478
Comments
Great idea! This would be a welcome addition for me |
The issue/comment you referenced which is yours btw is no way close to this and also that PR you referenced is about "fixing x close button animation". I don't know if you understood what I'm talking about but you were supposed to read before commenting |
Your second point (smooth switching) is not limited to the popup, it happens for all kinds of types. There is also a duplicate: #5016 |
It's actually older than that: #2863. |
@alienthief this issue requests multiple features. Could you please open separate issues for each of those (except 2, since there's #5016 for that)? |
@mhmdanas 🤦♂️ it's a revamp about one specific feature. popup player. it was supposed to have multiple points that's why i wrote "revamp" on the title please reopen the issue |
It doesn't matter that we're talking about one existing feature. The issue is precisely with the multiple points. |
@opusforlife2 what do you think about @mhmdanas point of closing this issue? |
@alienthief Of your 3 points, point 2 is a duplicate as vkay and I linked already. Anyway, this is not a revamp. It's two separate feature requests/bugs. Why? Because the code/UI changes aren't related at all. A dev could browse through issues, stumble on one of those, and choose to implement the removing "resizing" one, for example, and it would have no effect on the other. So it is better that there are two different issues for it. |
I don't think we should change the popup player UI. It's a legacy piece of code IMO. We should use Android's Picture in Picture API instead (Android 7/8+). There is an issue for that: #2223 |
Checklist
Describe the feature you want
The current popup player needs some revamp like:
Is your feature request related to a problem? Please describe it
Yes because sometimes inconvenience is a problem.
Additional context
A popup player from another video player (MX):
How will you/everyone benefit from this feature?
People will benefit from this because they will no longer be hustling to close the mini player they will just click the x button in the player to close, they won't experience that delay at the player switch and finaly they won't see that big ugly resizing text when adjusting the player size.
The text was updated successfully, but these errors were encountered: