Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching subscriptions aborts with "network error" if a PeerTube instance is down #5247

Open
UniqueActive opened this issue Dec 22, 2020 · 1 comment
Labels
bug Issue is related to a bug peertube Service, https://joinpeertube.org/

Comments

@UniqueActive
Copy link

UniqueActive commented Dec 22, 2020

Hello,

Description

I am subscribed to channels from several PeerTube instances in addition to YouTube channels. One of the PeerTube instances, "video.blender.org", currently has an expired certificate. When updating the "What's new" subscriptions feed, NewPipe fetches the first half of my subscriptions until it encounters the video.blender.org channel, at which point it aborts with "Network error" and does not fetch the rest of the subscriptions. It should also be noted that this does not only happen when a certificate is expired, but also when the server is unreachable for any other reason. I have previously experienced this issue with another instance that regularly went down, and I simply had to unsubscribe from all channels of that instance to be able to use NewPipe 😅

Steps to reproduce

  1. Be subscribed to several YouTube and PeerTube channels
  2. One of the PeerTube channels goes offline or the certificate expires (hard to reproduce manually)
  3. Refresh your subscriptions feed

Expected behaviour

NewPipe fetches subscriptions from every channel besides the ones that are offline.

Actual behaviour

NewPipe fetches subscriptions until it encounters one that is broken/offline, after which it abruptly stops, not fetching the rest of the subscriptions. The (correctly working) channels that come after the broken one are never fetched.

Suggested solution

When encountering an error while fetching a PeerTube channel's video, do not stop fetching subscriptions. Attempt to fetch all further subscriptions and at the end, simply indicate which channels were not fetched, and optionally the reason.

Thanks for your amazing work on NewPipe!

@triallax triallax added bug Issue is related to a bug peertube Service, https://joinpeertube.org/ labels Dec 24, 2020
@ThisIsPaulDaily
Copy link

ThisIsPaulDaily commented Dec 30, 2020

I can confirm this just started happening to me at about midnight Central Time 2020-12-30

I'm not sure I'm subscribed to peertubes, but I know one of the channels I subscribed to is deactivated or something.

I confirm that by unsubscribing to the one broken channel that I am able to refresh. I think it may have been peertube it was an old conference or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug peertube Service, https://joinpeertube.org/
Projects
None yet
Development

No branches or pull requests

3 participants