-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle peertube video url intent #4853
Comments
How did they add every possible url to the manifest? I don't understand from here |
@stom79 should be able to help you with it. he is the lead developer on that |
It's in a flavor, so the logic is here https://github.com/stom79/TubeLab/blob/develop/app/src/fdroid_full/AndroidManifest.xml <intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
<!-- The app is a good candidate for URL in https://domain.name/videos/watch/xxxxx-->
<data
android:host="*"
android:pathPrefix="/videos/watch/"
android:scheme="https" />
</intent-filter> |
Oh, I see. @TobiGr @TheAssassin @B0pol @opusforlife2 do you think this should be added as it is, or do you think it will create problems? |
It should have very few FP (afaik) due to the pattern for path. But if there is one, it redirects the URL to other apps. See, here for managing the intent: And here for forwarding to other apps: |
I really like this solution. Could we use a pattern for Invidious as well? |
That's already implemented in NewPipe, so just changing the manifest would be ok |
Have there been any news on this? |
Checklist
Describe the feature you want
currently newpipe can play peertube urls just fine but cannot accept direct links from apps. as in, if i have to play a peertube video, i have to either search or copy url and paste in search to run.
i am proposing to add url intent just like "tubelab" a peertube android app does.
it looks for videos/watch in the url and tries to play it or throw to other apps if unable to.
look here.
https://framagit.org/tom79/fedilab-tube/-/commit/824c4e0cbbf693467d79ac4195611b10aeff10e5#e6606aeb8715512e114c47ddfcf04b979958e466_223_224
a simple regex
Is your feature request related to a problem? Please describe it
currently newpipe plays peertube videos but does not understand url intent like it does for youtube links. pressing any youtube url plays that video in newpipe or at least asks us to. not the case with peertube. they open in browser which is less than ideal.
Additional context
How will you/everyone benefit from this feature?
peertube compatibility would be better now that livestreaming is a thing on peertube.
The text was updated successfully, but these errors were encountered: