Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Status bar color #3013

Open
CharlieBrown12 opened this issue Jan 26, 2020 · 5 comments
Open

(Feature request) Status bar color #3013

CharlieBrown12 opened this issue Jan 26, 2020 · 5 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface help wanted Help is wanted in fixing this issue

Comments

@CharlieBrown12
Copy link

Hi all - Status bar color looks very outdated compared to Action bar.

Can this be offered as an option in menus that Status bar color is the same color as Action bar? Visually it looks alot more appealing.

Alternatively - would be great if someone could point to code line that renders this, I looked through it but without luck.

@Stypox
Copy link
Member

Stypox commented Jan 26, 2020

The status bar is currently a little bit darker than the action bar... isn't that OK and conforming to Material Design?

@Stypox Stypox added feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface help wanted Help is wanted in fixing this issue labels Jan 26, 2020
@CharlieBrown12
Copy link
Author

CharlieBrown12 commented Jan 27, 2020

Thanks. I work in design for years and that darker shade in NewPipe is just not right.

Indeed - Material design guidelines recommend this but:

  1. Many apps in PlayStore offer the setting to color the status bar in the exact tone of action bar.

  2. Some Google apps like Gmail (versions from 2019 with red action bar) also have aligned statusbar and action bar (see screenshot from my phone).

  3. NewPipe is not on Google's recommended apps list.

I dont mean to cause any delay - you may try for yourself and see how NewPipe design looks Status bar in same tone as Action bar.
Meanwhile if you point me to the code line which does this - I would be grateful to try it.

@CharlieBrown12
Copy link
Author

Screenshot_20200127-100202_Chrome

@moneytoo
Copy link
Contributor

moneytoo commented Jan 27, 2020

I'm with Charlie on that. I cannot find it now but I believe that later revisions of MD allowed it. Yes, Gmail and some other 1st party apps switched to single color (also some samples) before going white. Chrome also dropped generating darker status bar color from themeColor and uses single color now.

@moneytoo
Copy link
Contributor

moneytoo commented Feb 3, 2020

Just trying to get rid of darker colorPrimaryDark results in looks like this:

device-2020-02-03-225722

I see that @Stypox already tracks that (make text white on red) in #3042 :)

@litetex litetex removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface help wanted Help is wanted in fixing this issue
Projects
None yet
Development

No branches or pull requests

4 participants