Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.17.4 #2715

Closed
TobiGr opened this issue Oct 11, 2019 · 16 comments
Closed

Release 0.17.4 #2715

TobiGr opened this issue Oct 11, 2019 · 16 comments
Labels
discussion This needs to be discussed before anything is done

Comments

@TobiGr
Copy link
Member

TobiGr commented Oct 11, 2019

Improved

Fixed

Development


APK for testing

newpipe_debug_0.17.4_RC3.apk.zip

Corresponding PR: #2710
PLEASE REPORT NEW CRASHES AND PROBLEMS BELOW

@TobiGr TobiGr mentioned this issue Oct 11, 2019
@TobiGr TobiGr pinned this issue Oct 11, 2019
@Redirion
Copy link
Member

Redirion commented Oct 11, 2019

Unable to install on my device. PackageManager install failure code -15.
/**
* Installation return code: this is passed to the {@link IPackageInstallObserver} by
* {@link #installPackage(android.net.Uri, IPackageInstallObserver, int)} if
* the new package failed because it has specified that it is a test-only
* package and the caller has not supplied the {@link #INSTALL_ALLOW_TEST}
* flag.
* @hide
*/
public static final int INSTALL_FAILED_TEST_ONLY = -15;

@TobiGr
Copy link
Member Author

TobiGr commented Oct 11, 2019

I am not sure what went wrong. I am able to install it. nevertheless, I rebuild the apk and it had a different sha256 sum. strange... Please test the new one

@Redirion
Copy link
Member

installation was okay now. Thanks!

@Redirion
Copy link
Member

btw. what about PR #2547 ? it is in "waiting for merge" state. Maybe this would be a good addition to have some visible changes with the new release?

@TobiGr
Copy link
Member Author

TobiGr commented Oct 12, 2019

I didn't have time to compare both pull requests dealing with the feed sorting (extractor as well as app), so I don't want to merge one of them. My plan is to review them as soon as this is merged and decide which one to use and release 0.18.0 after a short testing period.
IMO, it is not a good idea to merge one and replace that code two weeks later because there is a better implementation.

@koli6faizakhan
Copy link

Hii Iam using this app in smart TV. all working is fine but only one issue this app.That issue is Newpipe default player properly not control Tv remote so reslove next update.

@TobiGr
Copy link
Member Author

TobiGr commented Oct 15, 2019

@koli6faizakhan Does everything work correctly withi 0.17.3? You might be interested in testing the changes from #2701 which aims to improve TV support.

@TobiGr TobiGr mentioned this issue Oct 15, 2019
2 tasks
@Stypox Stypox added the discussion This needs to be discussed before anything is done label Oct 15, 2019
@Pentaphon
Copy link

So far, so good. The new Exoplayer version makes a difference.

@opusforlife2
Copy link
Collaborator

If #2736 is a small enough change, how about merging that as well?

@TobiGr
Copy link
Member Author

TobiGr commented Oct 20, 2019

I've uploaded (hopefully) the last RC for this release. In case the updated libs didn't break anything, I'd like to release tonight.

@Stypox
Copy link
Member

Stypox commented Oct 20, 2019

I tested roughly the player and the downloader and all seems to work

@SnwMds
Copy link

SnwMds commented Oct 25, 2019

Sometimes the following crash occurs when NewPipe receives a reCAPTCHA challenge:

Exception

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.hashCode()' on a null object reference
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getPlayerConfig(YoutubeStreamExtractor.java:660)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.onFetchPage(YoutubeStreamExtractor.java:638)
	at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:52)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:63)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:59)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:115)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$5fJcha6Sq5APJBLdG6osaJby-mc.call(Unknown Source:4)
	at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.Flowable.subscribe(Flowable.java:14479)
	at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.Maybe.subscribe(Maybe.java:4154)
	at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.Single.subscribe(Single.java:3438)
	at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
	at java.lang.Thread.run(Thread.java:764)


@theScrabi
Copy link
Member

@TobiGr from my point of view it looks fine and it works for me, however it seems there are still issues.

@TobiGr
Copy link
Member Author

TobiGr commented Oct 28, 2019

@theScrabi In this case, let's go. The reCAPTCHA issues should be fixed soon. but not in this release, we can release a hotfix for that as soon as there is a workaround.

@theScrabi
Copy link
Member

I'd be fine with that.

@TobiGr
Copy link
Member Author

TobiGr commented Oct 31, 2019

https://github.com/TeamNewPipe/NewPipe/releases/tag/v0.17.4

@TobiGr TobiGr closed this as completed Oct 31, 2019
@TobiGr TobiGr unpinned this issue Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done
Projects
None yet
Development

No branches or pull requests

8 participants