Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos will not scale to notch area #2682

Closed
haistakaavittukaikkisaatana opened this issue Oct 3, 2019 · 3 comments · Fixed by #2967
Closed

Videos will not scale to notch area #2682

haistakaavittukaikkisaatana opened this issue Oct 3, 2019 · 3 comments · Fixed by #2967
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface

Comments

@haistakaavittukaikkisaatana

When scaling videos they will not reach the notch area, so videos are not truly fullscreen.

Device: Note 10+
OS: Stock Pie 9.0

@Stypox Stypox added bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface labels Oct 3, 2019
@Stypox
Copy link
Member

Stypox commented Oct 3, 2019

Have you tried clicking on the "fit" button in the submenu of the main player, to change how the video renders?

@haistakaavittukaikkisaatana
Copy link
Author

Yes, and it will not fill to notch area.

@moneytoo
Copy link
Contributor

moneytoo commented Jan 18, 2020

I confirm this behaviour. It's because LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES is not specified. It's pretty straightforward to add (I can send a PR, it works fine for me when added).

But the question is in what viewing modes (Fit/Fill/Zoom) should the view actually extend to the cutout area. I would expect it at least in the Fill and Zoom modes. Personally I would also extend it in the Fit mode. Here's why:

  1. I basically only use MX Player (on OnePlus 7) and it extends to the cutout in all viewing modes (including "Fit to screen").

  2. I prefer to extent to view to cutout in Fit mode because 16:9 videos (on my 19.5:9 screen) are better horizontally centered and don't go near the non cutout side where display has rounded corners.

EDIT: I tried 21:9 video in Youtube app and it also extends video under the cutout (without providing any other viewing modes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants