Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Notes for download availability #2478

Open
Wilker-uwu opened this issue Jul 28, 2019 · 3 comments
Open

[Feature request] Notes for download availability #2478

Wilker-uwu opened this issue Jul 28, 2019 · 3 comments
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app soundcloud Service, https://soundcloud.com/

Comments

@Wilker-uwu
Copy link

i think that SoundCloud media should have in the Download button text, a note showing if the song is originally a free to download, a paid one, or if there was no link at all in the site. — e.g show as Download (No-link) if the upload did not mention any info about its availability nor gave a link, or show as Download (CC) if it is licensed under Creative Commons, or Download (Free, CC) if it is Creative Commons and it has a download link for the free download.

also the application should give the option to block or redirect (to the linked store or whatever) downloads of songs that are paid, with the text note shown in the same way as mentioned above.

an addition to #183 (comment)

@Stypox
Copy link
Member

Stypox commented Jul 28, 2019

I don't think this can be implemented without creating problems: looking for arbitrary links in descriptions is difficult and can lead to security problems if the parsed link leads to a malicious page.

@Wilker-uwu
Copy link
Author

i was thinking about just seeing the "free download"|"buy"|whatever buttons that usually appear in some uploads, not the ones in the description.

in any case, i think that the issue with security can be less of a problem if there could be a prompt like FairEmail does when opening any links, so the user can be alerted in case they might misclick or need to know where they're going with the link.

Screenshot of the prompt popup. The "Browse" button shows another prompt asking to choose which broser the user wants to open with, while "yes" just opens with the default webview.

@Stypox Stypox added downloader Issue is related to the downloader feature request Issue is related to a feature in the app soundcloud Service, https://soundcloud.com/ labels Oct 1, 2019
@B0pol
Copy link
Member

B0pol commented Feb 10, 2020

I don't think this can be implemented without creating problems: looking for arbitrary links in descriptions is difficult and can lead to security problems if the parsed link leads to a malicious page.

In fact it's really easy.
Look at this music, you can see a « Free Download » button.
Just add this method, if you want that feature, in SouncloudStreamExtractor.java

public isFree() throws ParsingException {
    try {
         return track.getString("purchase_title");
    } catch (Exception ignored) {
         return null;
}

It returns "Free download" for the track quoted above. If there is not that information, it returns null, such as with this music

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app soundcloud Service, https://soundcloud.com/
Projects
None yet
Development

No branches or pull requests

3 participants