Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider aspect ratio when playing back YT videos #11184

Closed
6 tasks done
virtualritz opened this issue Jun 16, 2024 · 6 comments
Closed
6 tasks done

Consider aspect ratio when playing back YT videos #11184

virtualritz opened this issue Jun 16, 2024 · 6 comments
Labels
player Issues related to any player (main, popup and background) question Not really an issue, but more of a question about how something works

Comments

@virtualritz
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

When playing back any video itgets stretched to 16:9 aspect in thumbnail view and to whatever aspect my phone has, in fullscreen. I.e. the original aspect of the video is ignored.

This means unless the video's aspect matches 16:9 in thumbnail or my phone's (16:10) by accident, everything in the video is squeezed.

THe settings should have an option for either adding black bars when the aspect mismatches or using zoom & crop.
Lacking this, the defaylt behaviour should be to use black bars.

Why do you want this feature?

Why would you ever watch a video where people look like they have been squeezed in a hydraulic press? 😁

Additional information

No response

@virtualritz virtualritz added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jun 16, 2024
@virtualritz
Copy link
Author

virtualritz commented Jun 16, 2024

Screenshot_20240616-202132

Screenshot_20240616-202148

@opusforlife2
Copy link
Collaborator

Toggling between fit/fill/zoom didn't fix this?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 18, 2024
@virtualritz
Copy link
Author

Toggling between fit/fill/zoom didn't fix this?

I didn't know this existed.
It's probbaly because it is a text, not an icon. And the fact it's a three-state toggle widget is oblivious.

So Fit is exacly what I am looking for.

I suggest:

  • Make Fit the default, not Zoom.
  • Moving this widget one level up, i.e. put it in the row with the resolution/speed/etc icons.
  • Making this an icon (that doesn't change, just tapping it cycles through the states as does tapping on the text does now).
    • Print the fill/fit/zoom word in the bottom right corner of the icon w. a small font size, to reflect state

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 18, 2024
@opusforlife2
Copy link
Collaborator

Make Fit the default, not Zoom.

It is already the default. If not you, someone else might have fiddled with that setting, possibly by accident.

@opusforlife2 opusforlife2 added question Not really an issue, but more of a question about how something works player Issues related to any player (main, popup and background) and removed feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jun 21, 2024
@virtualritz
Copy link
Author

virtualritz commented Jun 22, 2024

That is weird. I'm the only one using my phone.
But fair enough.
The other points still stand. Hard to discover/understand. I.e..once changed, even by accident, ...

@opusforlife2
Copy link
Collaborator

Let's wait for the player to be refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background) question Not really an issue, but more of a question about how something works
Projects
None yet
Development

No branches or pull requests

2 participants