Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocating the full screen button #11108

Closed
6 tasks done
stavpup opened this issue May 27, 2024 · 11 comments
Closed
6 tasks done

Relocating the full screen button #11108

stavpup opened this issue May 27, 2024 · 11 comments
Labels
Android TV Issue is related to Android TV duplicate Issue or discussion is a duplicate of an existing issue or discussion feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@stavpup
Copy link

stavpup commented May 27, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

IMHO there is a design flow, because the full screen button is on the right of the video bar, and if you press the right arrow to go there, it forwards the video in the bar and cannot move to the button. I found by accident that you must press the down button to get to it. So the current position is counter intuitive.

Why do you want this feature?

IMHO the full screen button, should be placed up and on the right, for example.
image

Additional information

No response

@stavpup stavpup added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels May 27, 2024
@SameenAhnaf SameenAhnaf added player Issues related to any player (main, popup and background) Android TV Issue is related to Android TV GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels May 31, 2024
@opusforlife2
Copy link
Collaborator

If you're on top-right arrow button and press Down, what happens?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@stavpup
Copy link
Author

stavpup commented May 31, 2024

If you're on top-right arrow button and press Down, what happens?

It does not take you to the full screen button. I tried it many times. I don't remember exactly where it takes you because it is a friend's tv. Either the progress bar or the play button in the middle.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@opusforlife2
Copy link
Collaborator

Alright, this needs more testing. Whenever you next get access, check if you're able to get access to the button in other ways.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@stavpup
Copy link
Author

stavpup commented May 31, 2024

No other way that what I have described.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@opusforlife2
Copy link
Collaborator

Still worth it to confirm once.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 1, 2024
@stavpup

This comment was marked as resolved.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 9, 2024
@opusforlife2

This comment was marked as resolved.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 10, 2024
@stavpup

This comment was marked as resolved.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 12, 2024
@opusforlife2
Copy link
Collaborator

Still worth it to confirm once.

This is pending.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 15, 2024
@stavpup
Copy link
Author

stavpup commented Jun 20, 2024

Still worth it to confirm once.

This is pending.

I confirm it

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 20, 2024
@opusforlife2
Copy link
Collaborator

Closing in favour of #11197.

@opusforlife2 opusforlife2 added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android TV Issue is related to Android TV duplicate Issue or discussion is a duplicate of an existing issue or discussion feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants