Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying video title for deleted videos opened from playlists #10827

Open
6 tasks done
Plugdemholes-Imeanpatchdembugs opened this issue Feb 15, 2024 · 8 comments
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people

Comments

@Plugdemholes-Imeanpatchdembugs

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.2

Steps to reproduce the bug

  1. Go into a playlists where any video was deleted from youtube
  2. the player tab opens, giving the name of the video and the message - content not available -
  3. You can still read the original video title but it can't be copied to the clipboard

Expected behavior

When the name still exists it should be possible to extract the videos name still 1:1 to the clipboard.

Actual behavior

long pressing on a videos title that was deleted from youtube does not result in that the video title gets copied to the clipboard, nothing happens.

Screenshots/Screen recordings

No response

Logs

since Newpipe doesn't crash I can't provide any logs

Affected Android/Custom ROM version

Android 11

Affected device model

Galaxy Tab A 8.0 (2019)

Additional information

I'm just asking to make this function work since it should be simple I guess and the video titles that are the issue here are also in part with Japanese kanji etc.
if it's not too much work, I would be happy if video titles could be pasted to the clipboard like with regular still existing videos to search for if the videos still exist even if outside of YT. Otherwise the only way I could think of is sitting with another phone and letting OCR run over each video title to have a chance to find it again.

best regards :)

@Plugdemholes-Imeanpatchdembugs Plugdemholes-Imeanpatchdembugs added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 15, 2024
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 15, 2024
@Plugdemholes-Imeanpatchdembugs
Copy link
Author

I'd like to argue it's a bug if it works for still existing videos but not for deleted ones?

@Plugdemholes-Imeanpatchdembugs Plugdemholes-Imeanpatchdembugs changed the title Playlists with deleted videos still hold the name of the video but the video title can't be copied to the clipboard Playlists with deleted videos still hold the name of the video but the video title can't be copied to the clipboard [works for still existing videos /bug] Feb 16, 2024
@opusforlife2
Copy link
Collaborator

A bug is a problem in the code. You're asking for an additional effort to be put in in order to add extra functionality that wasn't present before.

@opusforlife2 opusforlife2 changed the title Playlists with deleted videos still hold the name of the video but the video title can't be copied to the clipboard [works for still existing videos /bug] Allow copying video title for deleted videos opened from playlists Feb 16, 2024
@Plugdemholes-Imeanpatchdembugs
Copy link
Author

but isn't the code already existing if it works for every still existing video ?.?

@SameenAhnaf
Copy link
Collaborator

Well, no. Newpipe does not remember YouTube playlist video titles once you exit the app. It needs to be reloaded each time a YouTube playlist is open.

However, you are suggesting a new way for the app to work which was not intended. That's why, it's a feature request.

@Plugdemholes-Imeanpatchdembugs
Copy link
Author

but I can already copy video titles from playlists to the clipboard, this already works only for non-existing videos it's not working even though I still get shown the video title. Should I upload a video to illustrate?

@opusforlife2
Copy link
Collaborator

The devs didn't go "we'll allow copying titles except for this very specific case haha screw the users" and then modify the code to prevent you from copying the title. Nor did it happen accidentally, where they intended to have it work for deleted videos but it doesn't.

The ability to copy titles was added as a feature. The way this works is that it extracts this info from loaded video details. You're asking for it to be enabled in the case where video details aren't available because the video is deleted. This means adding extra code in order to accommodate your use case. This is the definition of a feature request.

@Plugdemholes-Imeanpatchdembugs
Copy link
Author

In that case, maybe I'll close this issue then.
I don't think it will benefit many people, the export possibility of playlists would bnefit more people.
I hoped it was just a piece of code that was broken. :(

@opusforlife2
Copy link
Collaborator

It is quite a niche use case. But there's no harm in leaving it open.

@opusforlife2 opusforlife2 added the niche Only relevant to a very small amount of people label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people
Projects
None yet
Development

No branches or pull requests

3 participants