Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerTube] Local kiosk unavailable on instances running PeerTube 6.0 and higher #10685

Open
6 tasks done
dragfyre opened this issue Dec 23, 2023 · 1 comment
Open
6 tasks done
Labels
bug Issue is related to a bug peertube Service, https://joinpeertube.org/ requires extractor change This issue requires a change to the extractor

Comments

@dragfyre
Copy link

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.26.0

Steps to reproduce the bug

Access the local kiosk page of any PeerTube instance that has installed PeerTube v6.0.0 or later (e.g. diode.zone, spectra.video...)

Expected behavior

The local kiosk page of a PeerTube instance that runs v6+ should display all videos that are local to that instance.

Actual behavior

Local kiosk pages of PeerTube instances that run v6+ display a "Content unavailable" error. See Additional Information regarding a breaking change in PeerTube's REST API which is the source of this bug.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

Since v6.0.0, PeerTube has removed the deprecated "filter" query from its REST API. The changelog notes:

Removed filter query when listing videos (deprecated since 4.0 in favour of isLocal and include)

A minor annoyance (as this issue only affects PeerTube instances which have updated to v6 and combined timelines still work properly), but I figured it's worth mentioning. It seems like all NewPipe versions are affected.

@dragfyre dragfyre added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Dec 23, 2023
@opusforlife2 opusforlife2 added peertube Service, https://joinpeertube.org/ and removed needs triage Issue is not yet ready for PR authors to take up labels Dec 23, 2023
@dragfyre
Copy link
Author

Relevant code found and PR submitted here.

@AudricV AudricV changed the title Peertube: Deprecated/removed "filter" query erroring [PeerTube] Local kiosk unavailable on instances running PeerTube 6.0 and higher Dec 28, 2023
@AudricV AudricV added the requires extractor change This issue requires a change to the extractor label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug peertube Service, https://joinpeertube.org/ requires extractor change This issue requires a change to the extractor
Projects
None yet
Development

No branches or pull requests

3 participants