Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License WebView scroll positive lost after device orientation change #10431

Open
6 tasks done
littlecd opened this issue Sep 19, 2023 · 1 comment
Open
6 tasks done

License WebView scroll positive lost after device orientation change #10431

littlecd opened this issue Sep 19, 2023 · 1 comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people

Comments

@littlecd
Copy link

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.2

Steps to reproduce the bug

  1. Go to About and view licenses
  2. scroll up
  3. rotate screen

Expected behavior

Scroll positive should be change

Actual behavior

The page scrolls to top

Screenshots/Screen recordings

Before rotation
Screen Shot 2023-09-19 at 2 33 22 PM

After rotation
Screen Shot 2023-09-19 at 2 33 32 PM

Logs

No response

Affected Android/Custom ROM version

Android 10

Affected device model

emulator

Additional information

No response

@littlecd littlecd added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Sep 19, 2023
@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Sep 19, 2023
@TobiGr
Copy link
Member

TobiGr commented Sep 19, 2023

I don't think that there is going to be an easy fix for this. The AlertDialog and the WebView are recreated on rotation, the old ones are removed from the view. Creating a complex logic to retrieve the nearest paragraph or something like that seems too much effort for something unimportant like a license view.

@TobiGr TobiGr removed the needs triage Issue is not yet ready for PR authors to take up label Sep 19, 2023
@opusforlife2 opusforlife2 added the niche Only relevant to a very small amount of people label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people
Projects
None yet
Development

No branches or pull requests

3 participants