Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newpipe subtitles own settings for devices without internal options #10320

Closed
6 tasks done
ChuckBartowski91 opened this issue Aug 9, 2023 · 8 comments
Closed
6 tasks done
Labels
Android TV Issue is related to Android TV feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@ChuckBartowski91
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Hello, would be great if at least we could resize subtitles into NewPipe, thanks.

Why do you want this feature?

Because on android tv they are too big and since it's android 7.0 for tv it has no separated subtitles setting.

Additional information

Trying to open the subtitles setting in NewPipe just shows "error" message.

@ChuckBartowski91 ChuckBartowski91 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Aug 9, 2023
@SameenAhnaf SameenAhnaf added player Issues related to any player (main, popup and background) Android TV Issue is related to Android TV and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 9, 2023
@opusforlife2
Copy link
Collaborator

Trying to open the subtitles setting in NewPipe just shows "error" message.

What is this error message? A toast? Or something else? What does it say?

Is this specific to your TV or does it happen across Android TV versions, or models? It could be a bug that needs to be fixed separately from this feature request.

@ChuckBartowski91
Copy link
Author

Trying to open the subtitles setting in NewPipe just shows "error" message.

What is this error message? A toast? Or something else? What does it say?

Is this specific to your TV or does it happen across Android TV versions, or models? It could be a bug that needs to be fixed separately from this feature request.

It's a toast notification which just says "error" surely caused by newpipe looking for android subtitles settings, but which the TV doesn't known where to find it since it doesn't have any.

For that reason i really believe that is just android TV version prior to 9.0 (or <8.0 maybe), since on any phone i tried it opens system setting for closed captions.

Unfortunately I have a TV with android tv 9.0 but now it's sent to the manufacturer for warranty repair or I would have tried on that, but I believe that it works on it.

@opusforlife2
Copy link
Collaborator

Let's wait for your TV to come back so we can confirm this.

@ChuckBartowski91
Copy link
Author

Let's wait for your TV to come back so we can confirm this.

Oh, ehm, I fear it's gonna need a long time though.

@opusforlife2
Copy link
Collaborator

There's no hurry. xD

@opusforlife2
Copy link
Collaborator

@ChuckBartowski91 Did your TV ever come back? Or was it lost to the universe?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 21, 2024
@ChuckBartowski91
Copy link
Author

@ChuckBartowski91 Did your TV ever come back? Or was it lost to the universe?

Yeah sorry about that. Took quite some time while after that they exchanged it with an android 11 one.

However as expected subtitles settings of this TV are more integrated with android so shows without problems.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 22, 2024
@opusforlife2
Copy link
Collaborator

Thanks for confirming! Then we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android TV Issue is related to Android TV feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants