Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search more relevant results at first in settings #10019

Open
6 tasks done
andrewChen-a opened this issue Apr 12, 2023 · 2 comments
Open
6 tasks done

Search more relevant results at first in settings #10019

andrewChen-a opened this issue Apr 12, 2023 · 2 comments
Assignees
Labels
feature request Issue is related to a feature in the app search Anything related to the search function

Comments

@andrewChen-a
Copy link

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.1

Steps to reproduce the bug

  1. click "Settings" on the left panel
  2. click search button on the right top
  3. input some words, such as "download f"
  4. and we can see that the search results may not be the best

Expected behavior

I want to get a better search results, but actual not
image

Actual behavior

No response

Screenshots/Screen recordings

this is before
QQ20230412-112852

this is after improvement, I change the way to get the score, think about n-grams, Jaccard similarity and edit distance , I think it works for the search function

newPipe_实现后

Logs

No response

Affected Android/Custom ROM version

android x

Affected device model

oppo

Additional information

I am android developer, and I wish I can help NewPipe more better, if my commit can merge, that will be my first contribution for open source project

@andrewChen-a andrewChen-a added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Apr 12, 2023
@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Apr 12, 2023
@SameenAhnaf
Copy link
Collaborator

The existing code works as expected. However, you are willing to change current behavior of the app. So, I am labeling this issue as feature request, not bug.

Please wait for a few days before opening a PR. Keep an eye on #10003 for the latest details.

I also assigned this issue to you so that others can know that this issue is already being worked on by someone else.

@andrewChen-a
Copy link
Author

The existing code works as expected. However, you are willing to change current behavior of the app. So, I am labeling this issue as feature request, not bug.

Please wait for a few days before opening a PR. Keep an eye on #10003 for the latest details.

I also assigned this issue to you so that others can know that this issue is already being worked on by someone else.

got it, thank you~

@SameenAhnaf SameenAhnaf added the search Anything related to the search function label Dec 28, 2023
@Stypox Stypox changed the title wish I can help to impove the search function Search more relevant results at first in settings Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app search Anything related to the search function
Projects
None yet
Development

No branches or pull requests

2 participants