Merge pull request #1411 from TeamCOMPAS/BugFix

Fixed random kick draw for MULLERMANDEL prescription

Author: ilyamandel

src/BaseStar.cpp

@@ -3837,7 +3837,7 @@ double BaseStar::DrawRemnantKickMullerMandel(const double p_COCoreMass,
         sigmaKick = OPTIONS->MullerMandelSigmaKickBH();
 	}
 
-    double quantile0 = gsl_cdf_gaussian_P(0.0, sigmaKick);  //quantile of 0 in the Gaussian CDF; the goal is to draw from the cut-off Gaussian since the kick must exceed 0
+    double quantile0 = gsl_cdf_gaussian_P(-1.0, sigmaKick);  //quantile of -1 in the Gaussian CDF; the goal is to draw from the cut-off Gaussian since the kick must exceed 0
     double rand = quantile0 + p_Rand * (1.0 - quantile0);
     remnantKick = muKick * (1.0 + gsl_cdf_gaussian_Pinv(rand, sigmaKick));
 

src/changelog.h

@@ -1610,7 +1610,9 @@
 //                                          - Added missing virtual declaration to ShouldEnvelopeBeExpelledByPulsations
 //                                          - Now calculate mass accretion rate for nuclear timescale mass transfer on the fly to match with donor mass loss rate set by donor mass loss (required to fit into Roche lobe) divided by time step
 //                                          - Fixed random draws of SN kicks to avoid artificial pile-up at boundaries of distribution
-//					    - Split --muller-mandel-sigma-kick into --muller-mandel-sigma-kick-NS and --muller-mandel-sigma-kick-BH
+//					                        - Split --muller-mandel-sigma-kick into --muller-mandel-sigma-kick-NS and --muller-mandel-sigma-kick-BH
+//  03.22.01  IM - July 20, 2025        - Defect repair
+//                                          - Fixed random kick draw for MULLERMANDEL prescription
 
 // Version string format is MM.mm.rr, where
 //
@@ -1621,7 +1623,7 @@
 // if MM is incremented, set mm and rr to 00, even if defect repairs and minor enhancements were also made
 // if mm is incremented, set rr to 00, even if defect repairs were also made
 
-const std::string VERSION_STRING = "03.22.00";
+const std::string VERSION_STRING = "03.22.01";
 
 
 # endif // __changelog_h__