Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4304 #4316

Open
wants to merge 2 commits into
base: release/4.0
Choose a base branch
from

Conversation

enescakar2148
Copy link

Description

The cause of the error is that the password validaion logic runs for both password fields at the same time. When entering the first password, the second password field is empty, which causes the 'passwords do not match' error. This can be fixed by updating the code as follows:

Issue tracker

Changes made:

The logic for the first password field validation has been updated:
• If the first password is not empty, proceed.
• If the second password field is empty or if the passwords match, proceed.
• If the file name is valid, proceed with “OK”.

Error conditions:
• If the first password is empty: “field_empty” error.
• If the second password is entered and does not match: “password_no_match” error.
• If the file name is invalid: “empty_string” error.

With this change:
• No error will be shown when entering the first password.
• When entering the second password, the matching check will be performed.
• If the passwords do not match, an error will be shown.

This improves the user experience by avoiding unnecessary error messages when entering the first password, and only showing the mismatch error when the second password is entered.

Contributors:

…d validation logic runs for both password fields at the same time. When entering the first password, the second password field is empty, which causes the 'passwords do not match' error. This can be fixed by updating the code as follows:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant