-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace e.printStackTrace() with Log.e(TAG, "Error on ...", e); #2755
Comments
I found 174 occurrences of /**
* Helper method to log exceptions
*
* @param object the object where the exception was caught, used to retrieve the class name
* @param ex the exception
*/
public static void e(Object object, Exception ex) {
Log.e(object.getClass().getSimpleName(), ex.toString());
} |
This make a whole lot of sense actually. I was already planning to have a form of abstraction over the logging. So that we can come to know of the silent errors from users, not just crash reports. |
I would see if there is a library for this, that already does this. |
@HoussemNasri this implementation could lead to leaking of parent class instance if used in anonymous objects (like lambdas) |
@EmmanuelMess I would like to work on this issue. Could you please assign it to me? |
i want to contribute i am begineer in open source |
@puranjayK Please confirm if @ilihas786 can take this over. @ilihas786 We'll assign it to you if there's no reply or if they confirm that they're no longer working on this. |
Is this issue open? |
@VishalNehra is this still valid for we're using |
Replace e.printStackTrace() with Log.e(TAG, "Error on ...", e);
The text was updated successfully, but these errors were encountered: