Add default screenshots URL and improve param handling #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces DEFAULT_SCREENSHOTS_URL for temporary screenshot hosting and updates AppletDirective to auto-generate fig URLs when not provided. Also refines parameter extraction and language handling for applet URLs.
douden
commented
Oct 24, 2025
Replaces the temporary screenshots URL with a permanent image URL based on DEFAULT_BASE_URL. Refactors parameter extraction and merging logic to improve clarity and ensure language parameter is set according to document settings.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a default URL for screenshot hosting and enhances the AppletDirective to automatically generate fig URLs when not provided. It also adds URL parameter extraction and merging logic, allowing parameters from the URL to be combined with other configuration options while respecting document language settings.
Key Changes
- Added automatic fig URL generation using DEFAULT_BASE_URL when fig option is not specified
- Implemented URL parameter parsing to extract and merge query parameters from the applet URL
- Added language parameter override based on document configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improves the check for url_params to ensure it is not an empty string before processing. Adds comments clarifying lack of validation and that language parameter is always overwritten.
Clarifies that only `url` and `name` are required parameters for an applet, not `fig`. Adds a note explaining the fallback behavior for the `fig` parameter and updates the parameters table for better documentation accuracy.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces DEFAULT_SCREENSHOTS_URL for temporary screenshot hosting and updates AppletDirective to auto-generate fig URLs when not provided. Also refines parameter extraction and language handling for applet URLs.