Skip to content

Commit d5717f2

Browse files
committed
replaced docker magic numbers
1 parent 0a1e28f commit d5717f2

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

piper/configurations.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ class Configuration:
1111
wait_on_iter = 0.5
1212
n_iters = 10
1313

14+
# docker start time and counter
15+
docker_wait_on_iter = 0.5
16+
docker_n_iters = 20
17+
1418
n_gunicorn_workers = 1
1519

1620
image_suffixes = set(['jpg', 'jpeg', 'png'])

piper/utils/docker_utils.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
import sys
44
from loguru import logger
55

6+
from piper.configurations import get_configuration
7+
8+
cfg = get_configuration()
9+
610
def get_image(docker_client, image_name):
711
try:
812
cur_image = docker_client.images.get(image_name)
@@ -163,10 +167,10 @@ def create_image_and_container_by_dockerfile(docker_client, path, image_tag, con
163167
if container.status == 'running':
164168
break
165169

166-
if i == 20:
170+
if i == cfg.docker_n_iters:
167171
logger.error(f'container {container_name} can`t start, status is {container.status}')
168172
sys.exit()
169-
time.sleep(0.5)
173+
time.sleep(cfg.docker_wait_on_iter)
170174

171175

172176
except docker.errors.APIError as api_e:

0 commit comments

Comments
 (0)