Skip to content

Commit c854861

Browse files
authored
Merge pull request #456 from TaskFlow-CLAP/CLAP-358
CLAP-358 로깅 닉네임 파싱 방식 변경
2 parents 0235534 + c0d26bf commit c854861

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/main/java/clap/server/config/aop/LoggingAspect.java

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import clap.server.common.annotation.log.LogType;
88
import clap.server.exception.BaseException;
99
import com.fasterxml.jackson.core.JsonProcessingException;
10-
import com.fasterxml.jackson.databind.JsonNode;
1110
import com.fasterxml.jackson.databind.ObjectMapper;
1211
import jakarta.servlet.http.HttpServletRequest;
1312
import jakarta.servlet.http.HttpServletResponse;
@@ -88,9 +87,9 @@ public Object logApiRequests(ProceedingJoinPoint joinPoint) throws Throwable {
8887

8988
private void handleLoginLog(int statusCode, HttpServletRequest request, String customCode, LogStatus logStatus, Object result) throws JsonProcessingException {
9089
if (statusCode == HttpStatus.SC_OK) {
91-
loggingPort.createAnonymousLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), getNicknameFromRequestBody(request));
90+
loggingPort.createAnonymousLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), getNicknameFromParameter(request));
9291
} else {
93-
loggingPort.createLoginFailedLog(request, statusCode, customCode, logStatus, getRequestBody(request), getNicknameFromRequestBody(request));
92+
loggingPort.createLoginFailedLog(request, statusCode, customCode, logStatus, getRequestBody(request), getNicknameFromParameter(request));
9493
}
9594
}
9695

@@ -102,14 +101,8 @@ private LogStatus getLogType(MethodSignature methodSignature) {
102101
}
103102
}
104103

105-
private String getNicknameFromRequestBody(HttpServletRequest request) {
106-
try {
107-
String requestBody = getRequestBody(request);
108-
JsonNode jsonNode = objectMapper.readTree(requestBody);
109-
return jsonNode.has("nickname") ? jsonNode.get("nickname").asText() : null;
110-
} catch (Exception e) {
111-
return null;
112-
}
104+
private String getNicknameFromParameter(HttpServletRequest request) {
105+
return request.getParameter("nickname");
113106
}
114107

115108
private String getRequestBody(HttpServletRequest request) {

src/test/java/clap/server/application/service/admin/RegisterMemberCsvServiceTest.java renamed to src/test/java/clap/server/application/service/admin/RegisterMemberCSVServiceTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import clap.server.application.port.inbound.domain.MemberService;
44
import clap.server.application.port.outbound.member.CommandMemberPort;
55
import clap.server.application.port.outbound.member.LoadMemberPort;
6+
import clap.server.application.service.admin.CsvParseService;
7+
import clap.server.application.service.admin.RegisterMemberCSVService;
68
import clap.server.domain.model.member.Department;
79
import clap.server.domain.model.member.Member;
810
import clap.server.domain.model.member.MemberInfo;

0 commit comments

Comments
 (0)