Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onHideListener to hide() & clearCurrent() methods #260

Conversation

jassielcastro
Copy link
Contributor

This PR allows to add the OnHideListener listener in a separate way to the current one when creating an Alerter

//Current code
Alerter.crete(activity)
    .setOnHideListener(listener)
    .show()

And this is a new proposal for the different possibilities of closing Alerter outside of its creation.

//Current code
Alerter.crete(activity)
    .show()

---
//New options to hide the Alerter with a listener
Alerter.hide {
   doSomething()
}

Alerter.clearCurrent(activity) {
    doSomething()   
}

@jassielcastro jassielcastro changed the title Added onHideListener to hide() & clearCurrent() methods Add onHideListener to hide() & clearCurrent() methods May 13, 2021
@kpmmmurphy
Copy link
Collaborator

That's super @jassielcastro, thanks for adding this! Looks all good from a code perspective. Please bump the version to 7.2.0 in the build.gradle file, and update the changelog - then we can get this merged 🚀

@jassielcastro
Copy link
Contributor Author

@kpmmmurphy Done! Let me know if I can help with anything else!

@kpmmmurphy kpmmmurphy merged commit fb1eb1f into Tapadoo:develop May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants