Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when parse an external android package record #5

Open
jhzzzz opened this issue Dec 6, 2023 · 1 comment
Open

Bug when parse an external android package record #5

jhzzzz opened this issue Dec 6, 2023 · 1 comment

Comments

@jhzzzz
Copy link

jhzzzz commented Dec 6, 2023

Hi, thanks for your library, it do helped me save a lot of time.

Just found a little bug, when parse a ndefmessage buffer which incude an external type of android package like android.com:pkg with payload com.blabla, it will failed with chunk not support.

the reason is NdefMessage.swift line 201:

typeIndex += 1; changed to typeIndex += typeLength; is ok.

@dshalaby
Copy link
Member

dshalaby commented Jan 8, 2024

Hi - thanks for noticing this and suggesting a fix. We'll look into that. So glad you found the library useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants