fix(lit-virtual): create Virtualizer instance before hostConnected (#1061)

Author: jpzwarte

.changeset/hip-eels-speak.md

@@ -0,0 +1,7 @@
+---
+'@tanstack/lit-virtual': patch
+---
+
+fix(lit-virtual): create Virtualizer instance before hostConnected
+
+When creating an instance of the reactive controller in `connectedCallback`, calling `addController` will synchronously call `hostConnected` on the controller. This means that `this.virtualizer` will still be `undefined`.

packages/lit-virtual/src/index.ts

@@ -25,8 +25,6 @@ class VirtualizerControllerBase<
     host: ReactiveControllerHost,
     options: VirtualizerOptions<TScrollElement, TItemElement>,
   ) {
-    ;(this.host = host).addController(this)
-
     const resolvedOptions: VirtualizerOptions<TScrollElement, TItemElement> = {
       ...options,
       onChange: (instance, sync) => {
@@ -35,13 +33,14 @@ class VirtualizerControllerBase<
       },
     }
     this.virtualizer = new Virtualizer(resolvedOptions)
+    ;(this.host = host).addController(this)
   }
 
   public getVirtualizer() {
     return this.virtualizer
   }
 
-  async hostConnected() {
+  hostConnected() {
     this.cleanup = this.virtualizer._didMount()
   }