[BUG] ignore non expandable rows when the expanded state changes #6116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35541e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRowExpanding now filters rows by their canExpand capability when toggling all-expanded; only rows that can expand are marked expanded. Other expanded-state handling and single-row expansion logic remain unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant T as Table UI
participant R as RowExpanding
participant S as ExpandedState
U->>T: click "toggle all expanded"
T->>R: toggleAllRowsExpanded(old = true)
alt old === true
R->>R: iterate visible row IDs
loop per row
R->>R: call getCanExpand(rowId)
alt canExpand == true
R->>S: mark rowId as expanded (oldExpanded[rowId] = true)
else canExpand == false
R-->>S: skip rowId
end
end
else old === false
R->>S: clear expanded state (unchanged behavior)
end
R->>T: call onExpandedChange(mapped setExpanded)
T->>U: UI updates accordingly
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/table-core/src/features/RowExpanding.ts (1)
211-213: Revert unnecessary stylistic change.The block statement with explicit return is functionally identical to the concise arrow body. Since
setExpandedreturnsvoid, consider reverting to the more concise form for consistency:-table.setExpanded = updater => { - return table.options.onExpandedChange?.(updater) -} +table.setExpanded = updater => table.options.onExpandedChange?.(updater)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/table-core/src/features/RowExpanding.ts(2 hunks)
🔇 Additional comments (1)
packages/table-core/src/features/RowExpanding.ts (1)
299-304: Good fix! Verify existing tests cover this scenario.This correctly filters out non-expandable rows when converting from
expanded: trueto an explicit object state. Previously, all rows were marked as expanded regardless of theircanExpand()status, which could lead to inconsistent state.Please verify that this change is covered by tests:
RichardHpa
changed the title
2 tasks
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
✅ Actions performedReview triggered.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Resolving the issue I bought up in #6115 where if the old expanded state is
trueand you change any of the expanded rows. It will also include rows that don't have expanded rows. This was then causing a situation where thegetExpandedDepthfunction was returning the wrong number as the state included rows that shouldn't have been includedI have just added a check to see if that row should be expandable before it gets added to the expandable state.
✅ Checklist
pnpm test:pr.🚀 Release Impact
Summary by CodeRabbit