feat(vue): allow dynamic Store instance#194
Open
wobsoriano wants to merge 2 commits intoTanStack:mainfrom
Open
feat(vue): allow dynamic Store instance#194wobsoriano wants to merge 2 commits intoTanStack:mainfrom
wobsoriano wants to merge 2 commits intoTanStack:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 4785f06.
☁️ Nx Cloud last updated this comment at |
@tanstack/angular-store
@tanstack/react-store
@tanstack/solid-store
@tanstack/store
@tanstack/vue-store
@tanstack/svelte-store
commit: |
Contributor
Author
|
Hi @teleskop150750, why the downvote? I would love your thoughts here 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useStore()function needs to be updated to accommodate dynamicStoreinstance values from@tanstack/db. See full discussion.This PR already reruns the
watchcallback when theStoreinstance changes but the.subscribecallback never get invoked. Tbh not sure if this is optimal but I don't see an obvious better way of reacting to@tanstack/db's compiledQuery changes.cc @crutchcorn