-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor(router-core): buildLocation can skip second interpolatePath if no params.parse function in the branch #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router-core): buildLocation can skip second interpolatePath if no params.parse function in the branch #6506
Conversation
…if no params.parse function in the branch
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
View your CI Pipeline Execution ↗ for commit 94cb898
☁️ Nx Cloud last updated this comment at |
in
buildLocationwe callinterpolatePathto get a string to matchgetMatchedRoutesto get a route branch that matchesinterpolatePathto get the "real" pathname to make a URLhowever if the route branch doesn't contain any
params.parsefunctions, the 2ndinterpolatePathis guaranteed to return the same string as the 1st one. So in those cases we can skip itbefore

after
