-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: pending component handling for initial load #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also sets match status to 'succes' only after lazy loaded components were loaded
|
View your CI Pipeline Execution ↗ for commit 6022972.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/create-start
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-config
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client-core
@tanstack/start-config
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
|
This update breaks my automated tests using |
|
@codepunkt this fixed the behavior of showing the pending component only after the configured timeouts upon the initial load. this has always worked as expected for subsequent client navigations but the first load did not adhere to that config. if you have more questions please come join our discord at https://discord.com/invite/tanstack-719702312431386674 |
|
@schiller-manuel, I just wanted to say a huge thanks for your fix. You seriously have no idea how much easier it was that you made my life. That bug with the pending components was completely breaking the composition of skeletons for the routing I’m currently working on. Then I updated… and boom, the issue I’d been banging my head against just vanished. You’re the hero of my day. Really, thank you! 🙌 |
|
This commit also broke all my tests with vitest and react-testing-library, and the solution I found was to wrap my tanstack router test adapter with |
|
@amarant, by the way, thank you for your solution. I'm currently facing some related issues, but not related to the changes of the PR. |
also sets match status to 'succes' only after lazy loaded components were loaded
fixes #3556
fixes #2183
fixes #2722