Skip to content

Conversation

@schiller-manuel
Copy link
Contributor

@schiller-manuel schiller-manuel commented Apr 24, 2025

also sets match status to 'succes' only after lazy loaded components were loaded

fixes #3556
fixes #2183
fixes #2722

also sets match status to 'succes' only after lazy loaded components were loaded
@nx-cloud
Copy link

nx-cloud bot commented Apr 24, 2025

View your CI Pipeline Execution ↗ for commit 6022972.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-24 21:09:20 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 24, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4044

@tanstack/create-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-router@4044

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4044

@tanstack/create-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-start@4044

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4044

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4044

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4044

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4044

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4044

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4044

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4044

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@4044

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4044

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@4044

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4044

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4044

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4044

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4044

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4044

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4044

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4044

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4044

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4044

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4044

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4044

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4044

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4044

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@4044

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4044

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4044

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@4044

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4044

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@4044

@tanstack/start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-api-routes@4044

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4044

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@4044

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4044

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4044

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4044

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-handler@4044

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4044

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-ssr@4044

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4044

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4044

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4044

commit: 6022972

@schiller-manuel schiller-manuel merged commit afdafcf into main Apr 24, 2025
6 of 7 checks passed
@schiller-manuel schiller-manuel deleted the fix-pending-component-initial-load branch April 24, 2025 21:09
@codepunkt
Copy link

This update breaks my automated tests using vitest and react-testing-library.
Can someone explain, in simple terms for someone not up to speed with the codebase, what this update did?

@schiller-manuel
Copy link
Contributor Author

@codepunkt this fixed the behavior of showing the pending component only after the configured timeouts upon the initial load. this has always worked as expected for subsequent client navigations but the first load did not adhere to that config.

if you have more questions please come join our discord at https://discord.com/invite/tanstack-719702312431386674

@radist2s
Copy link

radist2s commented May 6, 2025

@schiller-manuel, I just wanted to say a huge thanks for your fix. You seriously have no idea how much easier it was that you made my life. That bug with the pending components was completely breaking the composition of skeletons for the routing I’m currently working on. Then I updated… and boom, the issue I’d been banging my head against just vanished. You’re the hero of my day. Really, thank you! 🙌

@amarant
Copy link

amarant commented May 14, 2025

This commit also broke all my tests with vitest and react-testing-library, and the solution I found was to wrap my tanstack router test adapter with await waitFor(() => renderWithTsRouter(...)), is this also how you manage it @codepunkt ?
Just 200 test to update now...

@radist2s
Copy link

@amarant, by the way, thank you for your solution. I'm currently facing some related issues, but not related to the changes of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants