Start RC feedback (start script, writing to user files, "not found" component, integrations) #6668
s-h-a-d-o-w
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Love what I'm seeing so far in the RC, with the focus seemingly on transparency, simplicity and largely not reinventing things for which great tools already exist.
So I thought I'd give feedback on mostly some minor quality of life aspects.
Deploying to production
In the README generated when using the
create ...tool, you only describe how to build, not how to run. Generally, there's astartscript. Should we usepreviewto run production instead? If so, I think it should be renamedstart.Or should we just run
index.mjsdirectly? In which case, I'd recommend creating astartscript that does that. Themainproperty inpackage.jsonshould probably also point there.Writing to the user's files
On the rare occasion that a tool does this (tanstack start is only the second in 10 years I've seen do this), I find it very intrusive.
When it comes to the route tree, based on the TypeScript content, I suppose it can't be kept in memory. But why not simply isolate it to a clearly internal
.tanstackdirectory at project root?As for generating content in freshly created route files, it seems unnecessary to me. People can just copy/paste from
index.tsx. I think that's much preferable over the whole "maybe the dev server is running, maybe it isn't; maybe the user has already written something to the file, maybe they haven't" dance.Include a default "not found" component
Maybe it's because I'm used to nextjs but it seems strange to me to not have a simple "not found" component included but instead get a warning in the terminal.
Not only for developer convenience but also branding, I would strongly recommend including one and making it a good one. Tons of people know what the default nextjs 404 looks like.
NOT IMPORTANT: Require cross platform compatibility for integrations
First project, I was curious to see what the sentry integration does. Bunch of npm scripts that can't be run on Windows.
Now, I agree that Windows sucks. But Linux sucks too, if only for killing accessibility in the name of security.
Because of the nature of all OSes sucking to varying degrees, I think anything that is listed when running
create @tanstack/start) should run on all platforms. Plus, it's usually easy to achieve.(The sentry integration also made me wonder whether there is some "server start hook" and whether there should be one if there isn't. Like e.g. if the user puts an
index.tsat the root ofsrc, it'll be run on server startup. Or maybe options that can be passed to thetanstackStartvite plugin.)Beta Was this translation helpful? Give feedback.
All reactions