fix: solid scroll restoration

schiller-manuel · schiller-manuel · commit 6022972db9b0 · 2025-04-24T23:00:29.000+02:00
diff --git a/packages/solid-router/src/Transitioner.tsx b/packages/solid-router/src/Transitioner.tsx
@@ -31,9 +31,9 @@ export function Transitioner() {
   const previousIsPagePending = usePrevious(isPagePending)
 
   if (!router.isServer) {
-    router.startTransition = (fn: () => void) => {
+    router.startTransition = async (fn: () => void | Promise<void>) => {
       setIsTransitioning(true)
-      fn()
+      await fn()
       setIsTransitioning(false)
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -31,9 +31,9 @@ export function Transitioner() {`
`31`	`31`	`const previousIsPagePending = usePrevious(isPagePending)`
`32`	`32`
`33`	`33`	`if (!router.isServer) {`
`34`		`- router.startTransition = (fn: () => void) => {`
	`34`	`+ router.startTransition = async (fn: () => void \| Promise<void>) => {`
`35`	`35`	`setIsTransitioning(true)`
`36`		`- fn()`
	`36`	`+ await fn()`
`37`	`37`	`setIsTransitioning(false)`
`38`	`38`	`}`
`39`	`39`	`}`