feat(useQuery): enable the throwOnError option of useQuery.refetch
#907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch fails Enables the `throwOnError` configuration option for `useQuery.refetch` that has as of yet only been present in the documentation but not in the code. Relates to: TanStack#903 TanStack#843
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/rokvt4lwi |
boschni
reviewed
Aug 21, 2020
src/core/query.ts
Outdated
| } | ||
|
|
||
| async refetch(): Promise<void> { | ||
| async refetch(options?: { throwOnError?: boolean }): Promise<TResult | undefined> { |
Collaborator
There was a problem hiding this comment.
Maybe create a type like RefetchOptions to prevent some duplication?
Collaborator
|
Related discussion: #901 |
Member
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
throwOnErrorconfiguration option foruseQuery.refetchthat has as of yet only been present in the documentation but not in the code.Also returns the result of the fetch for consistency.
Relates to: #903 #843