type(query-core): add Override #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 967fd48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
More templates
@tanstack/angular-query-devtools-experimental
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
commit: |
Co-authored-by: Lee HyunJae (whale) <71202076+2-NOW@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7916 +/- ##
===========================================
+ Coverage 44.51% 61.85% +17.34%
===========================================
Files 195 135 -60
Lines 7279 4680 -2599
Branches 1629 1307 -322
===========================================
- Hits 3240 2895 -345
+ Misses 3662 1543 -2119
+ Partials 377 242 -135 |
manudeli
changed the title
manudeli
commented
Aug 23, 2024
Comment on lines
+23
to
+27
| export type Override<TTargetA, TTargetB> = { | ||
| [AKey in keyof TTargetA]: AKey extends keyof TTargetB | ||
| ? TTargetB[AKey] | ||
| : TTargetA[AKey] | ||
| } |
There was a problem hiding this comment.
I extract useful Override type from each framework packages to @tanstack/query-core to share it
TkDodo
approved these changes
Sep 8, 2024
This was referenced Sep 30, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.